[DD] Dispute Debt initial #33332
Merged
[DD] Dispute Debt initial #33332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Pongo
requested review from
amponce,
digitaldrk,
OptionSelect and
penny-lischer
This was referenced Dec 4, 2024
digitaldrk
reviewed
Dec 4, 2024
| }, | ||
| formId: VA_FORM_IDS.FORM_DISPUTE_DEBT, | ||
| saveInProgress: { | ||
| // messages: { |
There was a problem hiding this comment.
you want these comments here? NBD, feel free to resolve this.
There was a problem hiding this comment.
Yup! Left on purpose, we have follow on tickets to add these props. Thanks for spotting it!
digitaldrk
previously approved these changes
Dec 4, 2024
va-vfs-bot
temporarily deployed
to
master/dd/97002/new-app-initial/main
Dr-Pongo
added
the
digital-dispute
Open
15 tasks
va-vfs-bot
temporarily deployed
to
master/dd/97002/new-app-initial/main
Dr-Pongo
dismissed stale reviews from digitaldrk and OptionSelect
via
f8a824b
va-vfs-bot
temporarily deployed
to
master/dd/97002/new-app-initial/main
va-vfs-bot
temporarily deployed
to
master/dd/97002/new-app-initial/main
va-vfs-bot
temporarily deployed
to
master/dd/97002/new-app-initial/main
va-vfs-bot
temporarily deployed
to
master/dd/97002/new-app-initial/main
va-vfs-bot
temporarily deployed
to
master/dd/97002/new-app-initial/main
12 tasks
12 tasks
Dr-Pongo
force-pushed
the
dd/97002/new-app-initial
branch
from
f44444d to
8790ec3
Compare
va-vfs-bot
temporarily deployed
to
master/dd/97002/new-app-initial/main
digitaldrk
previously approved these changes
Dec 16, 2024
va-vfs-bot
reviewed
Dec 16, 2024
va-vfs-bot
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Sentry call found
Sentry captures a lot of data, and we want to make sure that we only keep information that will be useful for troubleshooting issues. This means that PII should not be recorded.
What you can do
Review your call to Sentry and see if you can reasonably reduce any information that is included, or wait for a VSP review.
va-vfs-bot
temporarily deployed
to
master/dd/97002/new-app-initial/main
|
Closing out as we need additional work |
10 tasks
|
Reopening into draft now that we have necessary changes and sister PR in content-build |
29 tasks
Andrew565
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Initial commit for digital dispute, much is still needed to call it complete though!
This PR inlcudes:
form.jsPrevious wonky PR: #33151
Related issue(s)
[DD] Initial FE implementation va.gov-team#97002
vets-json-schemaPRAdd schema for Dispute Debt vets-json-schema#961
vets-apifor prefill[DD] Initial prefill for digital dispute vets-api#19545
content-buildAdding dispute debt to registry content-build#2393
Testing done
Manual testing complete.
Screenshots
NOTE: these screenshots are initial implementation and do not represent the final product
/introduction/personal-information/contact-information/select-debt/existence-or-amount/0/dispute-reason/0/review-and-submit/confirmationWhat areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?