Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes My VA Health from VAOS direct schedule facility page #33516

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

ryanshaw
Copy link
Contributor

@ryanshaw ryanshaw commented Dec 12, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

This PR removes the My VA Health links from the VA facility page in within the direct schedule flow. Previously, the links were removed for a specific type of care in this PR

Related issue(s)

Testing done

  • Manual local testing replacing local mocked responses with staging responses for [email protected]
  • Unit tests

Screenshots

Before After
localhost_3001_my-health_appointments_($small-screen) (1) localhost_3001_my-health_appointments_($small-screen) (2)

Acceptance criteria

  • Regardless of whether or not the vaOnlineSchedulingOhDirectSchedule flag is on or off, there should be no My VA Health link next to any OH facility on the VA facility page within the direct scheduling flow

Quality Assurance & Testing

  • I updated unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@ryanshaw ryanshaw self-assigned this Dec 12, 2024
@ryanshaw ryanshaw marked this pull request as ready for review December 12, 2024 00:17
@ryanshaw ryanshaw requested review from a team as code owners December 12, 2024 00:17
Copy link
Contributor

@vbahinwillit vbahinwillit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanshaw ryanshaw merged commit 773ad70 into main Dec 12, 2024
83 of 85 checks passed
@ryanshaw ryanshaw deleted the ryanshaw/96902-remove-links-from-ds-flow branch December 12, 2024 17:58
Khoa-V-Nguyen pushed a commit that referenced this pull request Dec 16, 2024
* Removes My VA Health schedule links from VA facility page

* Removes unused tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants