[96836] Appoint a Rep prefill #33667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvcAdHoc
added
the
appoint-a-representative
va-vfs-bot
temporarily deployed
to
master/96836-prefill-frontend/main
va-vfs-bot
temporarily deployed
to
master/96836-prefill-frontend/main
jvcAdHoc
force-pushed
the
96836-prefill-frontend
branch
2 times, most recently
from
573bcdb to
ff86c22
Compare
jvcAdHoc
commented
Dec 20, 2024
| !!mockData && environment.isLocalhost() && !window.Cypress | ||
| ? mockData | ||
| : undefined, | ||
| // initialData: |
There was a problem hiding this comment.
This only impacts local development and can easily be uncommented to enable data seeding. It interfered with prefill.
cosu419
reviewed
Dec 20, 2024
| import { expect } from 'chai'; | ||
| import sinon from 'sinon'; | ||
| import ClaimantType from '../../../components/ClaimantType'; | ||
| import initialFormData from '../../fixtures/data/initial-form-data.json'; | ||
| import prefill from '../../fixtures/data/prefill.json'; | ||
| import formConfig from '../../../config/form.js'; |
There was a problem hiding this comment.
Can omit the .js extension here to satisfy the linter
|
|
||
| const ClaimantType = props => { | ||
| const { router, setFormData } = props; | ||
| const { router, setFormData, loggedIn } = props; | ||
|
|
||
| const { data: formData } = useSelector(state => state.form); |
There was a problem hiding this comment.
This isn't one of your changes, but I think formData should also be retrievable from props and useSelector shouldnt be necessary? If it's an easy update then we may as well make it now, otherwise I can approve.
There was a problem hiding this comment.
I switched to getting the form data from state like our other components
jvcAdHoc
force-pushed
the
96836-prefill-frontend
branch
from
2d41210 to
28edccf
Compare
cosu419
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Related issue(s)
Testing done
Before
Screen.Recording.2024-12-20.at.10.34.59.AM.mov
After
Screen.Recording.2024-12-20.at.10.29.18.AM.mov
What areas of the site does it impact?
Appoint a Rep Form 21-22 and 21-22a
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication