Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99461 The auth header adjusts capitalization so we should too #33780

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kjsuarez
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Correcting a discrepancy in capitalization between the user's first name in the auth header and in the MHV welcome message.

Related issue(s)

99461

Testing done

e2e spec added

Screenshots

Screenshot 2024-12-27 at 1 09 48 PM

What areas of the site does it impact?

MHV landing page

Acceptance criteria

MHV welcome message honors the capitalization applied to the auth header.
(preferred name unchanged, first name is capitalized)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants