Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 20190 - fix zips without bbox #33785

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Dec 27, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Adds bbox to features without bbox
  • Try using zipcode 91109 on FL for LH searches, does not work because no bbox
  • Sitewide team, we operate FL

Related issue(s)

Testing done

  • Manual testing of zipcode 91109

Screenshots

Screenshot 2024-12-27 at 1 00 31 PM

What areas of the site does it impact?

Facility Locator

Acceptance criteria

  • All zipcodes work, test with known issues

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Test on known zipcode issues and regular zipcodes without issues
Known issue
91109

@eselkin eselkin marked this pull request as ready for review December 27, 2024 21:02
@eselkin eselkin requested review from a team as code owners December 27, 2024 21:02
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-20190-some-zip-codes-crash-FL/main December 27, 2024 21:45 Inactive
@eselkin
Copy link
Contributor Author

eselkin commented Dec 27, 2024

There's a test that fails
src/applications/enrollment-verification/tests/unit/helpers.unit.spec.js
re:

paused payments calculation
         payments may be paused when two months have not been verified:

according to:
https://dsva.slack.com/archives/CBU0KDSB1/p1735315908788469
This is a test that will fail the last 2 weeks of the year because of a modulo operation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants