Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pnpm Update Command to Address Dependency Update Issues #11338

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Jan 17, 2025

What are you trying to accomplish?

This PR fixes the issue where the pnpm update command was being executed incorrectly as pnpm pnpm update.... The duplicate pnpm in the command caused errors and prevented updates from running as expected.

This fix ensures that the correct pnpm update command is used, improving the reliability of dependency updates for projects using pnpm.

What issues does this affect or fix?

  • Fixes the incorrect execution of the pnpm update command.
  • Resolves errors and unexpected behavior caused by running pnpm pnpm update.

Anything you want to highlight for special attention from reviewers?

  • This change specifically targets pnpm and ensures compatibility with its expected behavior for dependency updates.
  • Please confirm that no other areas of the code rely on the incorrect pnpm pnpm update pattern.

How will you know you've accomplished your goal?

  • Verifying that the corrected pnpm update command runs successfully without errors.
  • Ensuring that tests, especially those related to pnpm, pass and cover various update scenarios.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 marked this pull request as ready for review January 17, 2025 23:31
@kbukum1 kbukum1 requested a review from a team as a code owner January 17, 2025 23:31
Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

@kbukum1 kbukum1 merged commit 0997a4f into main Jan 17, 2025
86 checks passed
@kbukum1 kbukum1 deleted the kamil/fix-pnpm-update-command branch January 17, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants