Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

배포 1.0.2 #133

Merged
merged 13 commits into from
Mar 26, 2025
Merged

배포 1.0.2 #133

merged 13 commits into from
Mar 26, 2025

Conversation

jangwonyoon
Copy link
Collaborator

@jangwonyoon jangwonyoon commented Mar 26, 2025 •
edited by coderabbitai bot
Loading

  • 카드 생성 디버깅
  • 2차 MVP 카드 상세

Summary by CodeRabbit

  • New Features
    • 카드 상세 페이지의 뉴스, 취미, 포스트 등에서 데이터가 없을 때 명확한 빈 상태 표시 제공.
    • 태그 선택 인터페이스에 새로운 아이콘 도입 및 제출 버튼 문구 “명함 완성하기”로 변경, 알림 기능 추가.
  • Bug Fixes
    • 조직 및 지역 정보가 실제 데이터가 있을 때만 표시되도록 조건부 렌더링 개선.
    • 카드 생성 시 폼 리셋과 리다이렉션 처리를 강화하여 원활한 이용 환경 제공.
  • Refactor
    • 다단계 폼의 구조와 상태 관리 로직을 간소화하여 전반적인 UI 응답성 향상.

jangwonyoon and others added 13 commits March 26, 2025 00:43
@jangwonyoon
🐛 Fix: 썸네일 소속정보 에러 처기
d69b93a
@jangwonyoon
✨ Fix: 카드 생성 후 이동 라우트 수정
d265f16
@jangwonyoon
🐛 Fix: 카드 생성 기본이미지 blob 수정
779d894
@jangwonyoon
🐛 Fix: 카드 생성 대표 썸네일 인덱싱 수정
3a364e6
@jangwonyoon
✨ Feat: 카드 생성 페이지 토스터 적용
f54a81b
@jangwonyoon
🐛 Fix: 카드 생성 태그, 다시담기 후 상태 날라가는 문제 해결
63f2e6c
@jangwonyoon
✏️ Fix: 카드 생성 텍스트 수정
6ca3ee0
@jangwonyoon
♻️ Refactor: 카드 생성 코드 리팩토링
53fcdac
@JaeIn1
[feat] 받은 명함 상세 페이지 Empty 컴포넌트 추가 (#125)
f167df1 
* ✨ feat: 명함 상세 페이지 empty 컴포넌트 생성

* ♻️ refactor : 명함 상세 데이터 empty 케이스 예외처리

* ♻️ refactor : empty 조건문 수정

* refactor : 명함 상세 페이지 헤더 예외 처리 수정
@jangwonyoon
🐛 : 태그 선택 취소 시, form 필드 남아있는 에러 수정
d6cb835
@jangwonyoon
✨ Feat: 카드 생성 뒤로가기시 현재 form 상태를 제거하는 유틸함수 구현
59516ea
@jangwonyoon
Merge
0bc7545
@jangwonyoon
Merge pull request #129 from depromeet/fix/card-create
8a8b319 
debug: 카드 생성 페이지 디버깅
@jangwonyoon jangwonyoon added the auto approve PR에 대한 Auto Approve입니다. label Mar 26, 2025
@jangwonyoon jangwonyoon self-assigned this Mar 26, 2025
@jangwonyoon jangwonyoon marked this pull request as ready for review March 26, 2025 09:20
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 26, 2025 •
edited
Loading

Warning

Rate limit exceeded

@jangwonyoon has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between cc962ae and 8a8b319.

📒 Files selected for processing (30)
  • src/app/(create)/card-create/new-card/multi-step-form/page.tsx (1 hunks)
  • src/app/(create)/card-create/new-card/page.tsx (1 hunks)
  • src/app/(create)/card-create/page.tsx (1 hunks)
  • src/app/api/auth/callback/[provider]/route.ts (0 hunks)
  • src/features/card-detail/components/empty.tsx (1 hunks)
  • src/features/card-detail/mocks/myCardDetail.ts (2 hunks)
  • src/features/card-detail/ui/cardDetailHeader.tsx (2 hunks)
  • src/features/card-detail/ui/cardTabs.tsx (4 hunks)
  • src/features/card-detail/ui/domain.tsx (1 hunks)
  • src/features/card-detail/ui/posts.tsx (1 hunks)
  • src/features/card-detail/ui/projects.tsx (1 hunks)
  • src/features/card-detail/ui/recent.tsx (1 hunks)
  • src/features/card-detail/ui/sns.tsx (2 hunks)
  • src/features/multi-step-form/components/AvartarImg.tsx (2 hunks)
  • src/features/multi-step-form/config/index.ts (1 hunks)
  • src/features/multi-step-form/hooks/queries/useCreateCard.ts (1 hunks)
  • src/features/multi-step-form/ui/careerForm/config/index.ts (1 hunks)
  • src/features/multi-step-form/ui/careerForm/constants/index.ts (1 hunks)
  • src/features/multi-step-form/ui/careerForm/firstStep.tsx (2 hunks)
  • src/features/multi-step-form/ui/careerForm/fourthStep.tsx (3 hunks)
  • src/features/multi-step-form/ui/careerForm/index.tsx (4 hunks)
  • src/features/multi-step-form/ui/careerForm/secondStep.tsx (2 hunks)
  • src/features/multi-step-form/ui/careerForm/tagFormStep/ui/Ball.tsx (1 hunks)
  • src/features/multi-step-form/ui/careerForm/tagFormStep/ui/MotionTagBox.tsx (2 hunks)
  • src/features/multi-step-form/ui/careerForm/tagFormStep/ui/TagBox.tsx (3 hunks)
  • src/features/multi-step-form/ui/careerForm/thridStep.tsx (2 hunks)
  • src/features/multi-step-form/ui/index.tsx (1 hunks)
  • src/features/multi-step-form/utils/index.tsx (2 hunks)
  • src/shared/config.ts (1 hunks)
  • src/shared/store/cardFormState.ts (3 hunks)
📝 Walkthrough

Walkthrough

이 PR은 코드 간결화를 위해 JSX 프래그먼트를 제거하고 조건부 렌더링 로직을 수정하는 등 여러 컴포넌트의 리팩토링 작업을 포함합니다. 또한 인증 콜백 API 파일이 삭제되었으며, 새로운 Empty 컴포넌트가 추가되어 데이터가 없을 경우의 UI 처리 방식을 개선하였습니다. 다단계 폼에서는 초기값 상수, 리셋 로직, 상태 관리 및 제출 후 네비게이션 처리가 업데이트되었고, 아바타 이미지 처리 방식도 개선되었습니다. 추가로 태그 관련 설정과 스토어 업데이트가 이루어져 전반적인 폼 및 UI 기능 안정성을 높였습니다.

Changes

파일 변경 요약
src/app/(create)/card-create/.../page.tsx (new-card/multi-step-form, new-card, card-create) JSX 프래그먼트 제거, 컴포넌트를 직접 리턴하도록 간소화
src/app/api/auth/callback/[provider]/route.ts 인증 콜백 POST 요청 처리 파일 삭제
src/features/card-detail/components/empty.tsx
src/features/card-detail/mocks/myCardDetail.ts
src/features/card-detail/ui/cardDetailHeader.tsx
src/features/card-detail/ui/cardTabs.tsx
src/features/card-detail/ui/domain.tsx
src/features/card-detail/ui/posts.tsx
src/features/card-detail/ui/projects.tsx
src/features/card-detail/ui/recent.tsx
src/features/card-detail/ui/sns.tsx		 조건부 렌더링 로직 업데이트 및 Empty 컴포넌트 활용, 모의 데이터 값 수정
src/features/multi-step-form/components/AvartarImg.tsx 기본 아바타 이미지 처리 로직 수정 (blob 변환 및 nullish 연산자 사용)
src/features/multi-step-form/config/index.ts FIELD_TAG_MAPPING 제거, CARD_CREATE_INITIAL_VALUES 추가
src/features/multi-step-form/hooks/queries/useCreateCard.ts reset 콜백 파라미터 추가, 성공/오류 시 리셋 및 router.replace 사용
src/features/multi-step-form/ui/careerForm/**
src/features/multi-step-form/ui/index.tsx
src/features/multi-step-form/utils/index.tsx		 FormContext 도입, 불필요한 Zod/FormProvider 제거, 다단계 폼의 초기값, 리셋, 태그 처리 및 상태 관리 로직 개선
src/shared/config.ts
src/shared/store/cardFormState.ts		 tagConfig에 '소속 정보' 추가, handleTagClick 파라미터 확장 및 resetTagCount 메서드 추가

Suggested labels

♻️ refactor

Suggested reviewers

  • semnil5202
  • JaeIn1
  • youngju6143
  • evenway2025

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

evenway2025
evenway2025 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Collaborator

@evenway2025 evenway2025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 기준에서 이 코드는 이븐하게 잘 작성된 것 같습니다. 고생하셨습니다. Approve 드리겠습니다. 🎊

@jangwonyoon jangwonyoon added the 🐛 bug 버그 수정이 필요한 이슈 label Mar 26, 2025
@jangwonyoon jangwonyoon merged commit 6aa12e8 into main Mar 26, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenway2025 evenway2025 evenway2025 approved these changes

@semnil5202 semnil5202 Awaiting requested review from semnil5202 semnil5202 is a code owner

@JaeIn1 JaeIn1 Awaiting requested review from JaeIn1 JaeIn1 is a code owner

@youngju6143 youngju6143 Awaiting requested review from youngju6143 youngju6143 is a code owner

Assignees

@jangwonyoon jangwonyoon

Labels
auto approve PR에 대한 Auto Approve입니다. 🐛 bug 버그 수정이 필요한 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jangwonyoon @evenway2025 @JaeIn1