feat: 연구 결과 피드백 없을 때 마크업 #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesungoh
requested review from
oyeon-kwon,
sjoleee and
sumi-0011
as code owners
hyesungoh
commented
Mar 20, 2024
| import { HEAD_2_BOLD } from '~/styles/typo'; | ||
|
|
||
| const ResultBasePage: FC = () => { | ||
| const { data, isLoading } = useGetSurveyIdByUserStatus(); |
There was a problem hiding this comment.
요 훅 내부적으로 유저 상태를 enabled 옵션으로 쓰더라구요 ~
hyesungoh
commented
Mar 20, 2024
Comment on lines
+35
to
+41
| useEffect( | ||
| function replaceWhenHasFeedback() { | ||
| if (!data) return; | ||
| if (data.all_feedback_count > 0) router.replace('/result'); | ||
| }, | ||
| [data, router], | ||
| ); |
There was a problem hiding this comment.
피드백이 한 개라도 있는 사용자라면 리플레이스 함요 ~
hyesungoh
merged commit 76ba457
into
feature/survey-base/handle-created-survey
1 check passed
hyesungoh
added a commit
that referenced
this pull request
Mar 23, 2024
* feat: 설문이 있을 때 핸들링 * feat: 연구 결과 피드백 없을 때 마크업 (#492) * chore: 결과 베이스 이미지 * feat: mobile header props 뚫기 * feat: 결과 베이스
hyesungoh
added a commit
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
요거 만들어야돼용
🎉 변경 사항
MobileHeader에서 사이드 메뉴바를 감출 수 있는 prop을 뚫었어용