Fix screen resizer memory leak for mdl layout

[jakelauritsen]

No description provided.

[ribrdb]

This has several lint, build, and test failures

[jakelauritsen]

For testing I ran the mocha index test (which was only so helpful because everything has errors), and I'm duping everything over to the concatenated material.js file to verify on a local branch.

How are you seeing lint errors, and/or is there a better way to test?

[ribrdb]

I click open in codespace, then run: nvm install 11 nvm use 11 npm install npm run test

…

On Thu, Jul 18, 2024, 2:16 PM Jake Lauritsen ***@***.***> wrote: For testing I ran the mocha index test (which was only so helpful because everything has errors), and I'm duping everything over to the concatenated material.js file to verify on a local branch. How are you seeing lint errors, and/or is there a better way to test? — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAARUMI3BW53KV3R55OZVI3ZNAPAHAVCNFSM6AAAAABLBHWMPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXGQ4DKMBZGU> . You are receiving this because your review was requested.Message ID: ***@***.***>

[jakelauritsen]

I tried using the testing steps you provided, I keep getting errors, and this is the result of trying to run the tests on master:

[ribrdb]

Strange, tests are passing for me on master. Maybe try 'npm install' again?
Or if you merge from master the github action should work now.

Here's what I'm getting on your branch

[17:25:42] Failed to load external module @babel/register
[17:25:42] Requiring external module babel-register
[17:25:43] Using gulpfile /workspaces/material-design-lite/gulpfile.babel.js
[17:25:43] Starting 'clean'...
[17:25:43] Finished 'clean' after 19 ms
[17:25:43] Starting 'default'...
[17:25:43] Starting 'styles'...
[17:25:44] Starting 'styles-grid'...
[17:25:45] styles-grid all files 18.82 kB
[17:25:45] Finished 'styles-grid' after 880 ms
[17:25:47] styles all files 827.55 kB
[17:25:47] Finished 'styles' after 3.81 s
[17:25:47] Starting 'lint'...

src/layout/layout.js
  line 217  col 4  Unnecessary semicolon.

  ⚠  1 warning

jsDoc: Unexpected data in tag const at /workspaces/material-design-lite/src/layout/layout.js :
    18 |  'use strict';
    19 |
    20 |  /** @const @private */
---------------^
    21 |  const MEDIA_QUERY = window.matchMedia('(max-width: 1024px)');
    22 |  MEDIA_QUERY.onchange = screenSizeHandler;


1 code style error found.

events.js:170
      throw er; // Unhandled 'error' event
      ^
Error: JSHint failed for: src/layout/layout.js

[jakelauritsen]

Also let in the screenSizeHandler is not ES5 🙃