support for generating es6 imports and .d.ts files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribrdb
reviewed
Dec 9, 2024
| for (int i = 0; i < file->dependency_count(); i++) { | ||
| const std::string& name = file->dependency(i)->name(); | ||
| printer->Print("import * as $alias$ from '$file$';\n" | ||
| "goog.object.extend(proto, $alias$);\n", |
There was a problem hiding this comment.
goog.object.extend is deprecated, we should just use Object.assign.
Although I'm a little curios what's getting extended here. If this is building up a goog.module style namespace containing all protobufs, that's probably not something we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on protocolbuffers#150, adding:
libraryoption with ES6generate_dtsflag) and compatible (libraryoption set andimport_styleset toes6)Tested compilation of Derivita's omaha/base/ast.proto and inspecting the generated
omaha/base/ast_proto.jsandomaha/base/ast_proto.d.tsfiles.