Merge pull request #198 from desihub/doublet-ratio-bias

fix doublet bias
desihub · Dec 4, 2024 · e046107 · e046107
2 parents 51d851e + 34c1a91
commit e046107
Show file tree

Hide file tree

Showing 3 changed files with 89 additions and 154 deletions.
diff --git a/doc/changes.rst b/doc/changes.rst
@@ -5,7 +5,9 @@ Change Log
 3.1.1 (not released yet)
 ------------------------
 
-*
+* Fix <1% bias in fluxes and EWs of tied and free doublet ratios [`PR #198`_].
+
+.. _`PR #198`: https://github.com/desihub/fastspecfit/pull/198
 
 3.1.0 (2024-11-21)
 ------------------

diff --git a/py/fastspecfit/emline_fit/interface.py b/py/fastspecfit/emline_fit/interface.py
@@ -3,6 +3,8 @@
 
 from numba import jit
 
+from fastspecfit.resolution import Resolution
+
 from .params_mapping import ParamsMapping
 from .sparse_rep import EMLineJacobian
 
@@ -330,6 +332,11 @@ def _suppress_negative_fluxes(endpts, M):
                 for j in range(e-s):
                     M[i,j] = np.maximum(M[i,j], 0.)
 
+        if resolution_matrices is None:
+            # create trivial diagonal resolution matrices
+            rm = [ Resolution(np.ones((1, e - s))) for (s, e) in camerapix ]
+            resolution_matrices = tuple(rm)
+
         self.line_models = []
         _build_multimodel_core(line_parameters,
                                obs_bin_centers,
@@ -345,7 +352,6 @@ def _suppress_negative_fluxes(endpts, M):
             _suppress_negative_fluxes(endpts, M)
 
 
-
     def getLine(self, line):
         """
         Return a model for one emission line.