Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux estimate needs the MC parameters #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

moustakas
Copy link
Member

Tentative fix for #212.

@coveralls
Copy link

coveralls commented Mar 2, 2025

Pull Request Test Coverage Report for Build 13615871853

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.571%

Totals Coverage Status
Change from base Build 13497631213: 0.0%
Covered Lines: 3238
Relevant Lines: 6532

💛 - Coveralls

@moustakas
Copy link
Member Author

fastspec /global/cfs/cdirs/desi/spectro/redux/loa/healpix/sv3/bright/101/10147/redrock-sv3-bright-10147.fits \
  --targetids=39633301245265711 --input-seeds=3457684179 -o f.fits

Comparing main and this branch on the strong emission-line galaxy in #212, using the same seed, it looks like ONLY the ivar estimates are affected, not any of the fluxes (including those of the doublet ratios):

nn = Table(fitsio.read('f-new.fits', 'FASTSPEC'))
oo = Table(fitsio.read('f-main.fits', 'FASTSPEC'))
for col in nn.columns:
    if nn[col] != oo[col]:
        print(col, nn[col][0], oo[col][0])

NEV_3346_FLUX_IVAR 0.021939185 2820.3816
NEV_3346_EW_IVAR 2.4577835 409.10156
NEV_3426_FLUX_IVAR 0.13833664 2445382.2
NEV_3426_EW_IVAR 13.004872 1676040.9
OII_3726_FLUX_IVAR 0.005578641 0.35174468
OII_3726_EW_IVAR 0.23344408 0.35628211
OII_3729_FLUX_IVAR 0.006354813 0.15082723
OII_3729_EW_IVAR 0.1109968 0.22075365
NEIII_3869_FLUX_IVAR 0.051886078 3.7369142
NEIII_3869_EW_IVAR 1.4351236 3.6258779
H6_FLUX_IVAR 0.10293736 9.383136
H6_EW_IVAR 4.507912 13.065022
HEPSILON_FLUX_IVAR 0.040016633 5.541866
HEPSILON_EW_IVAR 1.2946771 1.727157
HDELTA_FLUX_IVAR 0.05129101 6.591297
HDELTA_EW_IVAR 2.8126767 9.920253
HGAMMA_FLUX_IVAR 0.1274502 1.5449232
HGAMMA_EW_IVAR 0.3909669 0.4423641
OIII_4363_FLUX_IVAR 0.11615272 342.8624
OIII_4363_EW_IVAR 5.742613 181.8196
HEI_4471_FLUX_IVAR 0.41805333 176.88634
HEI_4471_EW_IVAR 18.436285 131.69771
HEII_4686_FLUX_IVAR 0.005423398 0.0028202857
HEII_4686_EW_IVAR 0.23000531 0.12776475
HBETA_FLUX_IVAR 0.011032937 0.28220275
HBETA_EW_IVAR 0.056000378 0.10016822
OIII_4959_FLUX_IVAR 0.14940177 0.17817383
OIII_4959_EW_IVAR 0.02129282 0.023794675
OIII_5007_FLUX_IVAR 0.01667847 0.019890437
OIII_5007_EW_IVAR 0.003024844 0.0032189826
NII_5755_FLUX_IVAR 0.48496598 22385.682
NII_5755_EW_IVAR 12.108313 20699.996
HEI_5876_FLUX_IVAR 0.31115592 20.410435
HEI_5876_EW_IVAR 5.3178005 17.838171
OI_6300_FLUX_IVAR 0.34670892 42.514122
OI_6300_EW_IVAR 5.9166627 28.934818
SIII_6312_FLUX_IVAR 0.49973476 1075.7468
SIII_6312_EW_IVAR 8.89604 419.01147
NII_6548_FLUX_IVAR 1.5318081 106.37506
NII_6548_EW_IVAR 2.867179 2.7839673
HALPHA_FLUX_IVAR 0.019014642 0.02279589
HALPHA_EW_IVAR 0.0044757924 0.0044081556
NII_6584_FLUX_IVAR 0.16477476 11.442638
NII_6584_EW_IVAR 1.5077266 2.7994037
SII_6716_FLUX_IVAR 0.09890212 2.6995416
SII_6716_EW_IVAR 0.55985427 0.45180136
SII_6731_FLUX_IVAR 0.14201276 4.8715963
SII_6731_EW_IVAR 0.48210633 0.630577
ARIII_7135_FLUX_IVAR 0.8383342 48.641586
ARIII_7135_EW_IVAR 4.48035 12.105785
OII_7320_FLUX_IVAR 1.0091047 390.83215
OII_7320_EW_IVAR 9.5315485 168.39102
OII_7330_FLUX_IVAR 1.5100486 584.8507
OII_7330_EW_IVAR 17.955242 241.43822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants