Skip to content

Commit

Permalink
update cran comments for release
Browse files Browse the repository at this point in the history
  • Loading branch information
Fridolin Linder committed Feb 28, 2019
1 parent 42ac729 commit bdbde97
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
Version 1.2.3
Version 1.2.4

Fixed potential memory error from iterating over the beginning/end of a `std::map`
Fixed potential memory error from iterating over the beginning/end of a `std::map`. The last fix was apparently not enough. I was able to reproduce the issue using an ASAN instrumented R version and could resolve it. Hopefully the end of this issue.

## Test environments
* Mac OS 10.12.6 (High Sierra), R 3.5.1
* Ubuntu 16.04.5 LTS, R 3.5.1
* Ubuntu 14.04.5 LTS (travis-ci), R 3.5.1 (+ valgrind)
* Mac OS 10.12.6 (Mojave), R-devel instrumented with ASAN following instructions at https://www.stats.ox.ac.uk/pub/bdr/memtests/README.txt
* Mac OS 10.12.6 (Mojave), R 3.5.2
* Ubuntu 16.04.5 LTS (with valgrind), R 3.5.2
* Ubuntu 14.04.5 LTS (travis-ci), R 3.5.2
* win-builder (devel and release)

## R CMD check results

* No errors, warnings

* I got one note from R-hub about a possibly invalid URL: 'http://snap.stanford.edu/netinf/'. It seems like the site is temporarilly down but the URL is valid.
* No errors, warnings, notes

## Downstream dependencies
There are no downstream dependencies

0 comments on commit bdbde97

Please sign in to comment.