Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests for IdentityService and AccountService #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maebeam
Copy link
Contributor

@maebeam maebeam commented Apr 26, 2021

No description provided.

@maebeam maebeam requested a review from a team April 26, 2021 22:56
Copy link
Member

@lazynina lazynina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than addressing the todos, this looks great.

Comment on lines +147 to +158
// TODO: For some reason this is failing
// expect(lastPostMessage.payload.decryptedHexes).toEqual({
// [encryptedHex]: message,
// });
});

it('can handle info', () => {
// TODO
});

it('can handle jwt', () => {
// TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should address these todos before merging this in.

@deso-protocol deso-protocol deleted a comment from sonarqubecloud bot May 9, 2021
lazynina added a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants