Enhance form and widget button label functionality #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kagami-l
requested changes
Jan 5, 2024
There was a problem hiding this comment.
- radio的设计也更新了，需要改
- button不需要这两个按钮，加了的话得看前端实现会不会忽略
- submit/cancel两个值最好不是作为render函数的参数，而是__init__参数，并且可作为widget的property
参考设计文档变更：devchat-ai/devchat-website#4
yangbobo2021
force-pushed
the
enhance/form-button-labels
branch
from
367fbe9 to
9c3ebd0
Compare
kagami-l
requested changes
Jan 5, 2024
libs/chatmark/widgets.py
Outdated
| @@ -9,10 +9,12 @@ class Widget(ABC): | |||
| Abstract base class for widgets | |||
| """ | |||
|
|
|||
| def __init__(self): | |||
| def __init__(self, submit: Optional[str] = None, cancel: str = "Cancel"): | |||
libs/chatmark/widgets.py
Outdated
| @@ -249,12 +265,12 @@ def __init__( | |||
| # if default_selected is not None: | |||
| # assert 0 <= default_selected < len(options) | |||
There was a problem hiding this comment.
加了default_selected后，这段注释也恢复一下，检查下标是否越界
libs/chatmark/widgets.py
Outdated
Comment on lines
301
to
302
| if self._selection is not None and self._selection == idx: | ||
| lines.append(f"> X ({key}) {option}") |
There was a problem hiding this comment.
可以只判断 if self._selection == idx:，另外文档里x是小写，不确定前端解析到时是不是case-sensitive，这边还是按文档来吧
kagami-l
approved these changes
Jan 5, 2024
- Form and TextEditor classes now accept submit_button_name and cancel_button_name - Widget's chatmark header updated with customizable submit and cancel labels - Adjusted initialization of Checkbox and Radio classes with button label parameters
- Introduced the default_selected parameter in the Radio widget - Updated Radio widget to mark default selected option visually - Removed TODO comment for the default_selected implementation
- Add trailing commas to button name parameters in widgets - Reformat constructor definitions for consistency - Clean up unnecessary whitespace in widget render logic
- Make submit and cancel button labels optional in form and widgets - Refactor chatmark header construction for conditional button labels - Implement assertion for Radio widget's default_selected option
kagami-l
force-pushed
the
enhance/form-button-labels
branch
from
bb48e77 to
05d8e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two key features to enhance the user interface components:
default_selectedparameter has been added to the Radio widget, allowing a default option to be specified and visually marked when the widget is rendered.These updates aim to provide a more flexible and user-friendly experience with our UI components.
As there was no specific issue linked to these changes, there is no issue to close with this pull request.