Creating a new testing structure #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff does a couple things: - It creates test file for every Model and Document method that we'll need to handle and test. These can be gradually filled in. - It breaks helpers.js functions into separate files. Each one of those now has a corresponding test file. In upcoming diffs, I'll move the existing tests into this new structure.
|
Haven't been able to look at it in depth, but I'm a fan of the new structure. |
brysgo
reviewed
Jun 29, 2018
There was a problem hiding this comment.
I tried running the tests, and they pass despite an unhandled promise rejection.
✔ sanitizeDocumentList
✔ getUpdatePaths
index.test.js
(node:87895) UnhandledPromiseRejectionWarning: MongoError: ns not found
at /Users/goldstein bryan/workspace/mongoose-authz/node_modules/mongoose/node_modules/mongodb-core/lib/connection/pool.js:593:63
at authenticateStragglers (/Users/goldstein bryan/workspace/mongoose-authz/node_modules/mongoose/node_modules/mongodb-core/lib/connection/pool.js:516:16)
at Connection.messageHandler (/Users/goldstein bryan/workspace/mongoose-authz/node_modules/mongoose/node_modules/mongodb-core/lib/connection/pool.js:552:5)
at emitMessageHandler (/Users/goldstein bryan/workspace/mongoose-authz/node_modules/mongoose/node_modules/mongodb-core/lib/connection/connection.js:309:10)
at Socket.<anonymous> (/Users/goldstein bryan/workspace/mongoose-authz/node_modules/mongoose/node_modules/mongodb-core/lib/connection/connection.js:452:17)
at Socket.emit (events.js:180:13)
at Socket.emit (domain.js:422:20)
at addChunk (_stream_readable.js:274:12)
at readableAddChunk (_stream_readable.js:261:11)
at Socket.Readable.push (_stream_readable.js:218:10)
at TCP.onread (net.js:581:20)
(node:87895) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 5)
(node:87895) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
✔ Disable - find
✔ Disable - remove
|
Ah, it looks like that error happens when the code drops a collection that's not there. I'm not sure why that's happening since the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff does a couple things:
In upcoming diffs, I'll move the existing tests into this new structure.