Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure db bootstrapper runs on each deploy #124

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

hrodmn
Copy link
Contributor

@hrodmn hrodmn commented Feb 5, 2025

fix: ensure db bootstrapper runs on each deploy

fix: advertise secretBootstrapper so other resources can use it as a dependency

⚠️ Checklist if your PR is changing anything else than documentation

  • Posted the link to a successful manually triggered deployment workflow (successful including the resources destruction)

Merge request description

This ensures that the bootstrapper CustomResource will run on every deploy, which will ensure that any changes to the bootstrap process get executed rather than just updating the Lambda and not invoking it. resolves #113.

I also added the secretBootstrapper attribute so other constructs can add it as a dependency (resolves #123)

fix: advertise secretBootstrapper so other resources can use it as a
dependency
@hrodmn hrodmn requested a review from vincentsarago February 5, 2025 15:19
@vincentsarago
Copy link
Member

we need to pin pydantic-ssm-settings ~=0.2

@vincentsarago vincentsarago merged commit bb4bff8 into main Feb 6, 2025
4 checks passed
@vincentsarago vincentsarago deleted the fix/bootstrapper-updates branch February 6, 2025 07:46
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
## [7.5.1](v7.5.0...v7.5.1) (2025-02-06)

### Bug Fixes

* ensure db bootstrapper runs on each deploy ([#124](#124)) ([bb4bff8](bb4bff8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to database bootstrapper Lambda do not re-trigger the function
2 participants