Skip to content

Update items page to match collections page #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Conversation

oliverroick
Copy link
Member

  • Add new pagination layout
  • Add empty state when collection has no items
  • Remove jQuery dependency
  • Extend from base.html

- Add new pagination layout
- Add empty state when collection has no items
- Remove jQuery dependency
- Extend from base.html
@oliverroick
Copy link
Member Author

@vincentsarago can we merge this?

@vincentsarago
Copy link
Member

@oliverroick I'll have a look before the end of the week 🙏

<p>
<b>Number of matching items:</b> {{ response.numberMatched }}<br/>
<b>Number of returned items:</b> {{ response.numberReturned }}<br/>
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverroick can we add those back? it's always good to know how many items are available

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note response.numberMatched will only be set if the context extension is enabled in your pgstac instance

psql -d postgres -h 0.0.0.0 -p 5439 -U username -c 'SET SEARCH_PATH to pgstac, public; ALTER ROLE username SET pgstac.context TO 'on';'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note in the collections page we have a text like: Showing 1 - 10 of 30 collections

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I remove that because I didn't see the numberMatched. I've added Showing 100 of 395 items, similar to what we have on the collections page.

@vincentsarago vincentsarago merged commit e7d59d1 into main Mar 21, 2025
2 checks passed
@vincentsarago vincentsarago deleted the update-items-page branch March 21, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants