Update items page to match collections page #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliverroick
commented
Mar 6, 2025
oliverroick
commented
- Add new pagination layout
- Add empty state when collection has no items
- Remove jQuery dependency
- Extend from base.html
- Add new pagination layout - Add empty state when collection has no items - Remove jQuery dependency - Extend from base.html
|
@vincentsarago can we merge this? |
|
@oliverroick I'll have a look before the end of the week 🙏 |
| <p> | ||
| <b>Number of matching items:</b> {{ response.numberMatched }}<br/> | ||
| <b>Number of returned items:</b> {{ response.numberReturned }}<br/> | ||
| </p> |
There was a problem hiding this comment.
@oliverroick can we add those back? it's always good to know how many items are available
There was a problem hiding this comment.
note response.numberMatched will only be set if the context extension is enabled in your pgstac instance
psql -d postgres -h 0.0.0.0 -p 5439 -U username -c 'SET SEARCH_PATH to pgstac, public; ALTER ROLE username SET pgstac.context TO 'on';'
There was a problem hiding this comment.
Note in the collections page we have a text like: Showing 1 - 10 of 30 collections
There was a problem hiding this comment.
Ah yes, I remove that because I didn't see the numberMatched. I've added Showing 100 of 395 items, similar to what we have on the collections page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.