-
Notifications
You must be signed in to change notification settings - Fork 3
STAC: update stac-fastapi-pgstac version to 5.0 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"href": str(request.url_for("openapi")), | ||
} | ||
) | ||
request: Request = kwargs["request"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that collections
have been removed we don't need a custom landing_page
and can call super().landing_page(**kwargs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it - but we still need this custom method because we have the html response type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly
@@ -476,6 +416,37 @@ async def get_collection( | |||
|
|||
return collection | |||
|
|||
async def get_item( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-ordered methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding annotations about the custom responses and standardizing all of that logic at the end of each method!
"href": str(request.url_for("openapi")), | ||
} | ||
) | ||
request: Request = kwargs["request"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it - but we still need this custom method because we have the html response type
No description provided.