STAC: update stac-fastapi-pgstac version to 5.0 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
changed the title
vincentsarago
commented
Mar 20, 2025
| "href": str(request.url_for("openapi")), | ||
| } | ||
| ) | ||
| request: Request = kwargs["request"] |
There was a problem hiding this comment.
now that collections have been removed we don't need a custom landing_page and can call super().landing_page(**kwargs)
There was a problem hiding this comment.
got it - but we still need this custom method because we have the html response type
vincentsarago
commented
Mar 20, 2025
| @@ -476,6 +416,37 @@ async def get_collection( | |||
|
|
|||
| return collection | |||
|
|
|||
| async def get_item( | |||
There was a problem hiding this comment.
re-ordered methods
hrodmn
approved these changes
Mar 20, 2025
| "href": str(request.url_for("openapi")), | ||
| } | ||
| ) | ||
| request: Request = kwargs["request"] |
There was a problem hiding this comment.
got it - but we still need this custom method because we have the html response type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.