Skip to content

STAC: update stac-fastapi-pgstac version to 5.0 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

vincentsarago
Copy link
Member

No description provided.

@vincentsarago vincentsarago changed the title STAC: update stac-fastapi version to 5.0 STAC: update stac-fastapi-pgstac version to 5.0 Mar 20, 2025
@vincentsarago vincentsarago requested a review from hrodmn March 20, 2025 12:49
"href": str(request.url_for("openapi")),
}
)
request: Request = kwargs["request"]
Copy link
Member Author

@vincentsarago vincentsarago Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that collections have been removed we don't need a custom landing_page and can call super().landing_page(**kwargs)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it - but we still need this custom method because we have the html response type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly

@@ -476,6 +416,37 @@ async def get_collection(

return collection

async def get_item(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ordered methods

Copy link
Contributor

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding annotations about the custom responses and standardizing all of that logic at the end of each method!

"href": str(request.url_for("openapi")),
}
)
request: Request = kwargs["request"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it - but we still need this custom method because we have the html response type

@vincentsarago vincentsarago merged commit 0ca9fbc into main Mar 20, 2025
2 checks passed
@vincentsarago vincentsarago deleted the feature/stac-update-req5.0 branch March 20, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants