handle limit-offset in templates #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrodmn
approved these changes
Mar 24, 2025
vincentsarago
commented
Mar 24, 2025
| {% set urlq = url + '?' + params + '&' %} | ||
| {% else %} | ||
| {% set urlq = url + '?' %} | ||
| {% endif %} |
There was a problem hiding this comment.
Not sure why this was removed, sorry I should have caught this during review
oliverroick
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oliverroick I realized that we could access the
query-parametersdirectly in the template, instead of having to change the python code.FYI: I'm working on adding the HTML response into a Middleware, so I need to have templates that do not expect custom values provided, but just the regular stac-fastapi response