Adminforth user cleanup warning dialog #223
Conversation
| @@ -176,6 +176,19 @@ export const admin = new AdminForth({ | |||
| } | |||
| }, | |||
|
|
|||
| adminforthUserCleanupWarning: (adminUser: AdminUser) => { | |||
There was a problem hiding this comment.
@NoOne7135 hm, small misunderstanding here. AF developer should not configure anything to see this error. This error is to protect AF users and AF developers from security breach, so once i will merge this PR I think it will change nothing..
How exactly AF developers will know that such feature exist at all? Do you think they will open common.ts and read for all possible options? I think this is not what you are generally doing when starting using some library of framework. If you will mention it somewhere in doc - also there is no guarantee user reads whole doc. And price for the fact he will not read whole doc should not be a security!
I see point why you make it configurable because string 'adminforth' comes from af developer code, but anyway I think message itself should be fully injected into adminforth code and should not be configurable. For now we can simply assume that user with name adminforth should not exist. Maybe as option we can pass option "auth.warnIfUserEmailIs: 'adminforth'" and make it in app created with cli...
No description provided.