Feat: CentralState #366
Merged
Feat: CentralState #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwandor
reviewed
Feb 19, 2024
src/bluez/adapter.rs
Outdated
| @@ -22,6 +23,13 @@ impl Adapter { | |||
| } | |||
| } | |||
|
|
|||
| fn get_central_state(state: bool) -> CentralState { | |||
There was a problem hiding this comment.
Nit: Call the parameter powered rather than state.
src/bluez/adapter.rs
Outdated
| } if id == adapter_id => match adapter_event { | ||
| AdapterEvent::Powered { powered } => { | ||
| let state = get_central_state(powered); | ||
| Some(CentralEvent::StateUpdate(state.into())) |
There was a problem hiding this comment.
Why do you need the .into() here?
There was a problem hiding this comment.
i guess i dont need it :) fixed bcf31a7
szymonlesisz
force-pushed
the
feat/adapter_state
branch
from
087702b
to
bcf31a7
Compare
|
sorry for the force-push, too many fixes for |
|
wait this feature merged 😁 |
szymonlesisz
force-pushed
the
feat/adapter_state
branch
from
bcf31a7
to
523cc18
Compare
|
Hi, is there anything else i can do to push things forward? im expecting more conflicts with #388 |
szymonlesisz
force-pushed
the
feat/adapter_state
branch
from
523cc18
to
44d71ca
Compare
qwandor
reviewed
Sep 10, 2024
qwandor
approved these changes
Sep 10, 2024
szymonlesisz
force-pushed
the
feat/adapter_state
branch
from
3e09084
to
03c6acd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm working on bluetooth integration for trezor-suite app and i would like to use
btleplugas a bridge between the electron app and bluetooth device.To make it work i would like to contribute and address some missing features and issues
CentralState
Implementation of #280 for macos, windows and linux.
I wasn't sure should i extend existing
adapter_infomethod or just add newadapter_state, just for clarity i've added new function. I'm leaving this decision to you.Also i'm not sure about the naming
adapter_state() -> CentralStatei didn't want to mess up current naming convention.Feel free to nitpick anything.
Tested on Windows 10, macOS sonoma, linux nixOS
Commits
c244d41 add
CBManagerStategetter https://developer.apple.com/documentation/corebluetooth/cbmanagerstate incorebluetoothdelegate. The state is emitted inCentralDelegateEvent::DidUpdateStateevent.6cdb170 add
api::Adapter.adapter_statefunction andCentralEvent::StateUpdateevent, by default all targets returnsCentralState::Unknowne13a5e1 implementation for corebluetooth using delegate
centralmanager_stategetter08ef9a1 implementation for bluez using
BluetoothEvent::Adaptereventc608e55 implementation for winrtble using
Radio.State()https://github.com/microsoft/windows-rs/blob/master/crates/libs/windows/src/Windows/Devices/Radios/mod.rs -there might be some side effects, not sure why sometimes i'm receiving same event twice, but i don't mind that