Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: introduce assigned-clock-rates-u64 #140

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

MrVan
Copy link

@MrVan MrVan commented Jun 21, 2024

To support rates that exceeds UINT32_MAX, introduce assigned-clock-rates-u64

@MrVan
Copy link
Author

MrVan commented Jun 26, 2024

@robherring do you have time to give a look on this? Thanks.

dtschema/schemas/clock/clock.yaml Outdated Show resolved Hide resolved
To support rates that exceeds UINT32_MAX, introduce assigned-clock-rates-u64

Signed-off-by: Peng Fan <[email protected]>
@krzk
Copy link

krzk commented Jun 27, 2024

@robherring do you have time to give a look on this? Thanks.

BTW, before pinging someone you could answer to existing review. You do not need two reviewers telling you that 32-bit would not work. One reviewer is enough...

@@ -129,6 +129,8 @@ properties:
$ref: /schemas/types.yaml#/definitions/phandle-array
assigned-clock-rates:
$ref: /schemas/types.yaml#/definitions/uint32-array
assigned-clock-rates-u64:
$ref: /schemas/types.yaml#/definitions/uint32-array
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how does this exactly work for you? Can you show DTS example using this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`
assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>;

assigned-clock-rates-u64 = <0x1 0x1e1a3000>;
`

The linux patch: https://lore.kernel.org/all/[email protected]/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you can see it is not u32 value... Never mind.

@MrVan
Copy link
Author

MrVan commented Jun 27, 2024

@robherring do you have time to give a look on this? Thanks.

BTW, before pinging someone you could answer to existing review. You do not need two reviewers telling you that 32-bit would not work. One reviewer is enough...

@krzk sorry, I not see comment in this page before I asked Rob to comment. From go through this page, I only see Rob has a comment several hours before.

@MrVan
Copy link
Author

MrVan commented Jun 27, 2024

@robherring do you have time to give a look on this? Thanks.

BTW, before pinging someone you could answer to existing review. You do not need two reviewers telling you that 32-bit would not work. One reviewer is enough...

@krzk sorry, I not see comment in this page before I asked Rob to comment. From go through this page, I only see Rob has a comment several hours before.

My gmail shows
image

@robherring robherring merged commit 650bf2d into devicetree-org:main Jun 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants