Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KUBECONFIG gets set when using --kubeconfig via var DEVSPACE_FLAGS #2860

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

siredmar
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2859

Please provide a short message that should be published in the DevSpace release notes
Environment variable KUBECONFIG gets set when using --kubeconfig via variable DEVSPACE_FLAGS within devspace.yaml

What else do we need to know?

Copy link

netlify bot commented May 29, 2024

Deploy Preview for devspace-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d8978ac
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/66eadf184d58890007fa84d1

@siredmar siredmar force-pushed the fix/kubeconfig-devspace_flags branch from 336ba90 to b254376 Compare May 29, 2024 08:19
@siredmar
Copy link
Contributor Author

siredmar commented Jun 3, 2024

@FabianKramm, @LukasGentele would any of you guys mind reviewing this?

@lizardruss
Copy link
Collaborator

@siredmar Can you take a look at the e2e test failures?

@siredmar
Copy link
Contributor Author

siredmar commented Jul 10, 2024

@lizardruss

TL;DR Would you mind re-running the pipeline?

The failing e2e test seems like a problem with the OCI registry. Not sure if this is actually related to my change as both e2e tests for k8s 1.27.3 and 1.28.0 fail with the same error in different test cases both at exactly the same time (18:21:11).
https://github.com/devspace-sh/devspace/actions/runs/9282659759/job/26246098358?pr=2860#step:8:5178
https://github.com/devspace-sh/devspace/actions/runs/9282659759/job/26246097543?pr=2860#step:8:3116

@siredmar
Copy link
Contributor Author

@lizardruss please trigger a re-run of the e2e tests. Thanks.

@lizardruss lizardruss force-pushed the fix/kubeconfig-devspace_flags branch from b254376 to d8978ac Compare September 18, 2024 14:09
@lizardruss
Copy link
Collaborator

Unsure why linting suddenly fails, but I can address those in a separate PR.

@lizardruss lizardruss merged commit e873c8f into devspace-sh:main Sep 18, 2024
17 of 18 checks passed
@siredmar siredmar deleted the fix/kubeconfig-devspace_flags branch September 18, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--kubeconfig cannot be set via DEVSPACE_FLAGS
2 participants