Fix erratic livequery tests. #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change how we wait until an expected result is emitted from a live query. Current tests were more prone to timing issues and race conditions. Now we instead do the following for those tests: 1. Define the expected results 2. Subscribe to live query and wait until the expected results arrive, or a timeout of 500 ms happens. The thing is that liveQueries might emit a previous result at first, so by ignoring temporary outdated results we're not prone to timing issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unit tests for liveQuery, change how we wait until an expected result is emitted from a live query. Current tests were more prone to timing issues and race conditions. Now we instead do the following for those tests:
The thing is that liveQueries might emit a previous result at first, so by ignoring temporary outdated results we're not prone to timing issues except for the theoretical situtation that a liveQuery would take more than 500ms to emit expected result - which is practically irrellevant on the hardwares and queries we test.