97 update data for q4 202324 #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch '97-update-data-for-q4-202324' of https://github.com/dfe-analytical-services/apprenticeships-provider-dashboard into 97-update-data-for-q4-202324 # Conflicts: # datafiles_log.csv # manifest.json
axcooper
requested review from
johalastrahol,
MichaelEllisDFE and
RickBakerDFE
|
Going to close this and just add any additional changes to Q1 2024/25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Updated for Q4 2023/24
Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app())styler::style_dir()andlintr::lint_dir())What is the current behaviour?
Was for Q3 2023/24. Also have sorted out the problem with the hard coded LAD boundaries, so this needs to be incorporated into main before Q1 2024/25
What is the new behaviour?
Anything else