Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

103 update for q 1 202425 #105

Merged
merged 3 commits into from
Feb 10, 2025
Merged

103 update for q 1 202425 #105

merged 3 commits into from
Feb 10, 2025

Conversation

axcooper
Copy link
Collaborator

@axcooper axcooper commented Feb 7, 2025

Pull request overview

  • Updated the data for Q1 2024/25
  • In the check-file_sizes file, have put in all years for the demographic parquet, so can identify the largest
  • Have sorted the issue with the lad boundaries - just needed to specify the latest year as an option

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

Data is for 2023/24

What is the new behaviour?

Data is for Q1 2024/25

Anything else

  • In the check-file_sizes file, have put in all years for the demographic parquet, so can identify the largest

  • Have sorted the issue with the lad boundaries - just needed to specify the latest year as an option
    the bit below means that it doesn't matter which quarter it is - only takes the first bit ie academic year

    boundary_list <- list(
      "2024/25" = lad_boundaries_2024,
      "2023/24" = lad_boundaries_2024,
      "2022/23" = lad_boundaries_2023
    )
    
    # Choose the boundary based on the year selection from the user
    # think this will sort the hard -coding for the boundary list
    # will match to the first bit of the string - just the academic year & not qr
    return(boundary_list[[substring(input$year, 1, 7)]])
    

    })

…dance it, and for check file sizes for demographics, have put in all years to select the largest
@axcooper axcooper linked an issue Feb 7, 2025 that may be closed by this pull request
Copy link
Contributor

@johalastrahol johalastrahol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New 24/25 Aug to Oct data presents the correct visual graphics and maps

@johalastrahol johalastrahol merged commit afc7bd1 into main Feb 10, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Q 1 2024/25
2 participants