custom message when table empty #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johalastrahol
approved these changes
Feb 7, 2025
…e-found-in-the-table
|
message: no rows found is the default - have changed to 'No results for this provider in this year' |
Merge branch '52-page-5-add-custom-message-when-no-rows-are-found-in-the-table' of https://github.com/dfe-analytical-services/apprenticeships-provider-dashboard into 52-page-5-add-custom-message-when-no-rows-are-found-in-the-table # Conflicts: # manifest.json
|
Not currently letting me approve the changes |
rmbielby
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Adding custom message where NPS page is empty
Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app())styler::style_dir()andlintr::lint_dir())What is the current behaviour?
Generic message of no rows found.
What is the new behaviour?
...
Anything else