Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating with live data for 21st Nov publication #106

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Updating with live data for 21st Nov publication #106

merged 1 commit into from
Nov 21, 2024

Conversation

t-surtees
Copy link
Contributor

Pull request overview

Give a general description of why a change is being made, include issue number(s) being fixed if relevant

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?

Data updated.

What is the new behaviour?

Data updated. Manual dates back to automated.

Anything else

Add any notes for people reviewing and testing your code that are appropriate. Tag a @person to review if someone in particular needs to see this.

@t-surtees t-surtees requested a review from c-h-rowe November 21, 2024 09:23
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2024
View reviewed changes
server.R
@@ -1480,8 +1480,8 @@
most_recent_fullweek_date <- live_attendance_data_weekly() %>%
pull(week_commencing)

# paste0("Data on this tab relates to the week commencing ", most_recent_fullweek_date, ".")
paste0("Data on this tab relates to the week commencing 2024-10-21.")
paste0("Data on this tab relates to the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 94 characters. Note

Lines should not be more than 80 characters. This line is 94 characters.
server.R
# paste0("Data on this tab relates to the week commencing ", most_recent_fullweek_date, ".")
paste0("Data on this tab relates to the week commencing 2024-10-21.")
paste0("Data on this tab relates to the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data on this tab relates to the week commencing 2024-10-21.")

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.
server.R
@@ -1503,8 +1503,8 @@
as.Date(attendance_date) + 31
# as.Date(attendance_date) + 38

paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.
server.R
@@ -1503,8 +1503,8 @@
as.Date(attendance_date) + 31
# as.Date(attendance_date) + 38

paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 206 characters. Note

Lines should not be more than 80 characters. This line is 206 characters.
server.R
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 209 characters. Note

Lines should not be more than 80 characters. This line is 209 characters.
server.R
@@ -1528,8 +1528,8 @@
as.Date(attendance_date) + 31
# as.Date(attendance_date) + 38

paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 206 characters. Note

Lines should not be more than 80 characters. This line is 206 characters.
server.R
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 209 characters. Note

Lines should not be more than 80 characters. This line is 209 characters.
server.R
@@ -1553,8 +1553,8 @@
as.Date(attendance_date) + 31
# as.Date(attendance_date) + 38

paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.
server.R
@@ -1553,8 +1553,8 @@
as.Date(attendance_date) + 31
# as.Date(attendance_date) + 38

paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 206 characters. Note

Lines should not be more than 80 characters. This line is 206 characters.
server.R
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 209 characters. Note

Lines should not be more than 80 characters. This line is 209 characters.
c-h-rowe
c-h-rowe approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@c-h-rowe c-h-rowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for publication date, 21 Nov 2024.

@t-surtees t-surtees merged commit a69449d into main Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-h-rowe c-h-rowe c-h-rowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-surtees @c-h-rowe