EES-4727: Tidying up the data_ingestion code by adding types and spli… #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoutram
force-pushed
the
EES-4727/data-ingestion-tidy-up
branch
from
a298841 to
bc0a864
Compare
…tting up methods for parsing content.
benoutram
force-pushed
the
EES-4727/data-ingestion-tidy-up
branch
from
bc0a864 to
9ee5a96
Compare
sambiramairelogic
approved these changes
Dec 7, 2023
benoutram
force-pushed
the
EES-4727/data-ingestion-tidy-up
branch
from
b813ff1 to
8a2e518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to further tidy up the data ingestion module.
It splits up parsing content into multiple methods to make the code easier to read.
To make the code easier to read and allow for code analysis it adds explicit function parameter types, return types, and some argument name prefixes.
It simplifies
utils.chunk_textto only chunk text.It fixes a bug trying to extract content from content blocks and now only does it if they are of type 'HtmlBlock'.
It handles methodologies not being found by slug in EES which is occurring with the local EES data volume currently (cause still to be investigated).