Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier and smoother to run playwright tests locally #4960

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

sambiramairelogic
Copy link
Contributor

This is purely an optional quality of life PR, but it's been bugging me that we have to install playwright each time in order to run the tests, and that we can't run the playwright tests from the root directory with a single command.

I've also been meaning to install @frontend to the playwright-tests project so it can more safely import redirects.js.

This PR adds the playwright-tests project to the pnpm workspace so that playwright is installed during pnpm i, and adds a command to run tests from root.

@saicharan2789
Copy link
Collaborator

saicharan2789 commented Jun 17, 2024

Hi @sambiramairelogic - I had spined up the local environment and ran the below commands : 1 pnpm i and 2
pnpm test:playwright inside the root directory. I am able to run the playwright tests, However all the tests are failing now
image

@sambiramairelogic sambiramairelogic force-pushed the EES-XXXX/quality-of-life/simply-how-playwright-is-setup branch from 7142375 to 942f637 Compare June 21, 2024 15:20
@sambiramairelogic sambiramairelogic force-pushed the EES-XXXX/quality-of-life/simply-how-playwright-is-setup branch from 942f637 to d5add20 Compare July 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants