🐛 EES-5656 Only apply active class for navigation links if the location is matched exactly #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoutram
force-pushed
the
EES-5656_ReleaseOrder_NavLink_Change
branch
from
8848a40 to
0804b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug on the Release order page after #5442 which renamed the Admin's 'Legacy releases' page to 'Release order'.
The 'Release order' page was updated to use the route
/publication/:publicationId/releases/orderinstead of/publication/:publicationId/legacyby that change.However this meant the React router's nav link for the 'Releases' page on route
/publication/:publicationId/releasesalso had the active style applied while on the 'Release order' page since it's matching on the first part of the location.This PR adds
exacttoRouterNavLinmkinNavLinkso that the active class/style is only be applied if the location is matched exactly.Before:
After:
I checked to make sure I couldn't see any problems where
NavLinkis used but if any arise we could consider passingexactas a prop to control the value.Thanks to @amyb-hiveit who pointed me in the direction of the fix. 🙂