Skip to content

Commit

Permalink
Fix: Removing american Zs (#71)
Browse files Browse the repository at this point in the history
  • Loading branch information
JT-39 authored Jan 9, 2025
1 parent e2e4f9a commit 65a14af
Show file tree
Hide file tree
Showing 6 changed files with 934 additions and 926 deletions.
30 changes: 19 additions & 11 deletions 01_data/02_prod/development_update_log.csv
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
"Type","Summary","Details","Date"
"Feature","Initial message","The development of the new R-Shiny LAIT is now complete! While the tool’s core functionality remains unchanged, the user experience has been significantly enhanced. Key features like interactive charts, easy downloads, and accessibility-friendly styling aim to empower users to extract meaningful insights on children’s services with ease.

Looking ahead, we’re excited about potential future enhancements, such as:

- Visualizing quartile bands for better comparisons.
- Enabling users to deselect geographies from the LA page charts.
- Highlighting years where local authorities’ values are statistically above or below average.

We’d love to hear your ideas! If you have suggestions for new features, please let us know by submitting a [feature request issue on GitHub](https://github.com/dfe-analytical-services/local-authority-interactive-tool/issues/new/choose).",2024-12-13
"Chore","Test","Test log for development",2024-12-05
"Type","Summary","Details","Date"
"Feature","Initial message","The development of the new R-Shiny LAIT is now complete! While the tool’s core functionality remains unchanged, the user experience has been significantly enhanced. Key features like interactive charts, easy downloads, and accessibility-friendly styling aim to empower users to extract meaningful insights on children’s services with ease.



Looking ahead, we’re excited about potential future enhancements, such as:



- Visualising quartile bands for better comparisons.

- Enabling users to deselect geographies from the LA page charts.

- Highlighting years where local authorities’ values are statistically above or below average.



We’d love to hear your ideas! If you have suggestions for new features, please let us know by submitting a [feature request issue on GitHub](https://github.com/dfe-analytical-services/local-authority-interactive-tool/issues/new/choose).",2024-12-13
"Chore","Test","Test log for development",2024-12-05
2 changes: 1 addition & 1 deletion R/fn_analysis.R
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ filter_region_data_all_la <- function(data, la_names) {
#' This function filters a given BDS dataset to include only the rows that
#' match the specified indicators. It removes any rows where the year value
#' is missing (NA). The filtered dataset can be used for further analysis
#' or visualization of selected indicators.
#' or visualisation of selected indicators.
#'
#' @param bds_data A data frame containing BDS data, including a column
#' for indicators (`Measure`) and years (`Years`).
Expand Down
2 changes: 1 addition & 1 deletion R/fn_plotting.R
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ calculate_y_range <- function(data_long) {
#'
#' @return A numeric vector of 'pretty' breaks for y-gridlines, ensuring
#' that gridlines extend beyond the minimum and maximum values for better
#' visualization.
#' visualisation.
#'
#' @examples
#' # Example usage:
Expand Down
2 changes: 1 addition & 1 deletion R/lait_modules/mod_create_own_inputs.R
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ Create_MainInputsServer <- function(id, topic_indicator_full) {
#' Year Range Input UI
#'
#' This function creates a user interface component for selecting a range
#' of years. It utilizes a picker input to allow users to select one
#' of years. It utilises a picker input to allow users to select one
#' or more years from the available options.
#'
#' @param id A unique identifier for the Shiny module.
Expand Down
8 changes: 4 additions & 4 deletions R/lait_modules/mod_region_charts.R
Original file line number Diff line number Diff line change
Expand Up @@ -638,9 +638,9 @@ Region_MultiChartInputUI <- function(id) {

#' Region Multi-Chart Input Server Module
#'
#' A server-side module that handles the selection and synchronization of regions
#' A server-side module that handles the selection and synchronisation of regions
#' for comparing multiple charts (line and bar). It ensures that the selected regions
#' for both charts are valid and synchronized. The module also retains the user’s
#' for both charts are valid and synchronised. The module also retains the user’s
#' previous selections and updates the UI accordingly.
#'
#' @param id The unique module ID used to namespace input and output elements
Expand All @@ -655,14 +655,14 @@ Region_MultiChartInputUI <- function(id) {
#'
#' @return This function does not return a value directly. It renders the user
#' interface elements and ensures that the inputs for the line and bar charts
#' are synchronized, valid, and updated based on user selection.
#' are synchronised, valid, and updated based on user selection.
#'
#' @details The module performs the following tasks:
#' - Ensures that only valid region selections (those not equal to the selected
#' local authority) are allowed for the line and bar charts.
#' - Retains previous selections for both charts and updates the inputs with
#' valid options when the user changes the main LA or indicator.
#' - Synchronizes the line and bar chart inputs so that they both reflect the
#' - Synchronises the line and bar chart inputs so that they both reflect the
#' same selected regions, with a maximum of three regions selected for each chart.
#' - Returns the selected regions for both the line and bar charts as reactive values
#' for use in other parts of the app.
Expand Down
Loading

0 comments on commit 65a14af

Please sign in to comment.