Skip to content

Commit

Permalink
Eesp review fixes (#49)
Browse files Browse the repository at this point in the history
* Chore: Removing compact table setting from info page

* Feat: New navigation style - same as apprenticeship, cookies not quite working

* Chore: Added gov link colour

* Feat: Updated dfeshiny to use the new header() fn

* Chore: Deleted unused example_tab file

* Chore: Removing overflow site

* Chore: Standardising site title useage, improving custom_disconnect_message

* Fix: Cookies still not working properly possibly

* Chore: Moving footer and left navigation fns to helper

* Chore: Storing the main panels in their own scripts in ui_panels

* Chore: Removing useShinydashboard() from ui

* Chore: Tidying footer code

* Chore: Changed .csv to CSV

* Fix: Adding generic_ggiraph_options() to error plots

* Fix: Using dfereactable on error tables

* Fix: Replacing window_title logic to suit new navigation method

* Fix: Corrected the cookies issue where the id was too strict so banner link not working

* Feat: Adding pages id to bookmark so footer pages included too

* Chore: Improving clarity of Create Your Own downlaod data from github msg

* Chore: Changing text spinners to black and adding color option to with_gov_spinners()

* Chore: Moving navigation fns to ui_layout fn script

* Feat: Improving column names for LA and Regions also removing unecessary card headers

* Chore: Standardising all tabs, also made tab text not bold

* Chore: More consistent font sizes on Create Your Own inputs

* Chore: Adding more header and intro info to Create Your Own page

* Chore: Adding tooltip and rank colname for All LA regions table

* Feat: Adding alt-text options for charts

* Feat: Hiding copy to clipboard button and plot from screen readers

* Feat: Download UI calculates actual size of the download, both table and image

* Feat: Removing image filesize calc due to time taken

* Feat: Dataset file size now calculating based on size of csv or xlsx dataset (not id name)

* Chore: Adding spinning gear icon on developer updates to hidden for screen readers

* Chore: Updating email contacts for team email

* Feat: Ammending the support panel so it shows relevant info - still some test text in there

* Feat: Adding return to the top button

* Chore: Making contents title break words

* Fix: Change id for download file text logic as was same as the button id

* Fix: Screenshot of charts now working as added shinyWidgets::useShinydashboard() back in

* Fix: Removing screenshot tests and shinyWidgets::useShinydashboard()

* Chore: Increase chart download modal size so fits the text (file size info)

* Chore: Seperating out the calculate_file_size fn from the file_type_input_btn fn
  • Loading branch information
JT-39 authored Dec 12, 2024
1 parent c35a878 commit e820902
Show file tree
Hide file tree
Showing 39 changed files with 3,733 additions and 3,583 deletions.
52 changes: 26 additions & 26 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
# How to contribute

Thank you for looking to contribute to our project! The following document outlines our contributors guidance.

## Reporting bugs or features

If you spot a bug or feature you want to report, please check first that it has not been reported as an [issue](https://github.com/dfe-analytical-services/shiny-template/issues) already.

If no issue is open for your bug or feature, please [open a new one](https://github.com/dfe-analytical-services/shiny-template/issues/new)

Please use the templates provided to ensure that there is sufficient detail in your reported issue.

## Pull requests

If you have written some code that fixes a bug or feature, please push this up in a new branch under the format "bug/issue" and open this as a new PR when it is ready to review.

- Ensure the PR description clearly describes the problem and solution.
- Include the relevant issue number if applicable.

### Code styling

All code is styled using the styleR package. Running the `styler::style_dir()` function before pushing up to branch ensures that your code is in line with our style, and passes the pre-commit hooks.

## Any other questions

If you have any other questions, please do not hesitate to contact us at jake.tufts@education.gov.uk or [email protected]
# How to contribute

Thank you for looking to contribute to our project! The following document outlines our contributors guidance.

## Reporting bugs or features

If you spot a bug or feature you want to report, please check first that it has not been reported as an [issue](https://github.com/dfe-analytical-services/shiny-template/issues) already.

If no issue is open for your bug or feature, please [open a new one](https://github.com/dfe-analytical-services/shiny-template/issues/new)

Please use the templates provided to ensure that there is sufficient detail in your reported issue.

## Pull requests

If you have written some code that fixes a bug or feature, please push this up in a new branch under the format "bug/issue" and open this as a new PR when it is ready to review.

- Ensure the PR description clearly describes the problem and solution.
- Include the relevant issue number if applicable.

### Code styling

All code is styled using the styleR package. Running the `styler::style_dir()` function before pushing up to branch ensures that your code is in line with our style, and passes the pre-commit hooks.

## Any other questions

If you have any other questions, please do not hesitate to contact us at Darlington.BRIDGE@education.gov.uk or [email protected]
11 changes: 2 additions & 9 deletions 02_dev/info_pages/dev_user_guide.R
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,8 @@ ui_dev <- function(input, output, session) {
shinyGovstyle::banner(
"beta banner",
"beta",
paste0(
"This Dashboard is in beta phase and we are still reviewing performance
and reliability. ",
"In case of slowdown or connection issues due to high demand, we have
produced two instances of this site which can be accessed at the
following links: ",
"<a href=", site_primary, " id='link_site_1'>Site 1</a> and ",
"<a href=", site_overflow, " id='link_site_2'>Site 2</a>."
)
"This Dashboard is in beta phase and we are still reviewing performance
and reliability. "
),

# Start of app ============================================================
Expand Down
Loading

0 comments on commit e820902

Please sign in to comment.