Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #421

Merged
merged 18 commits into from
Feb 6, 2025
Merged

Development #421

merged 18 commits into from
Feb 6, 2025

Conversation

pauljamesdfe
Copy link
Contributor

Pull request overview

Give a general description of why a change is being made, include issue number(s) being fixed if relevant

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?

Please describe the current behaviour that you are modifying, or link to a relevant issue. Include screenshots for UI changes where possible.

What is the new behaviour?

Please describe the behaviour or changes that are being added by this PR. Include screenshots for UI changes where possible.

Anything else

Add any notes for people reviewing and testing your code that are appropriate. Tag a @person to review if someone in particular needs to see this.

pauljamesdfe and others added 18 commits January 22, 2025 14:58
Ammend code to import new column names
Made sure we weren't reading that data in twice by altering the combineData file
Readjusted the MCA names in global.R
…combined authority, so i have adapted the nomis functions to get data at this level
Because there is no LA data to build up from, utilise any other matching geographic areas to use as MCAs
@pauljamesdfe pauljamesdfe merged commit b9f0f55 into main Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants