Reactable example #107
Merged
Reactable example #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmbielby
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Couple of small comments to just remove data table. We're just wanting to push a single preferred solution.
Looks like a lot of lintr comments around unnecessary white space. Worth running styler::style_dir() if you haven't already.
Just to add as well, it'd be good to get some of the GDS style highlighting in as demoed in the css on one of our dashboards here:
https://github.com/dfe-analytical-services/local-authority-interactive-tool/blob/9f7aa4d06969614f55b002b50502a514d3c1d320/www/dfe_shiny_gov_style.css#L294
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rmbielby
requested changes
Dec 19, 2024
adding Rich's additions to css Co-authored-by: Rich Bielby <[email protected]>
…-services/shiny-template into reactable-example
rmbielby
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Reactable example beneath datatable example
...
Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app())styler::style_dir()andlintr::lint_dir())What is the current behaviour?
...
What is the new behaviour?
...
Anything else
issue #84
...