Fix header logo issues #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amended run_example to have alt text for logo. appl;ied stlye_pkg to code
cjrace
approved these changes
Dec 30, 2024
Co-authored-by: Cam Race <[email protected]>
Co-authored-by: Cam Race <[email protected]>
Co-authored-by: Cam Race <[email protected]>
cjrace
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes
addresses this issue : 63
Changed the code for logo images so that they are inverted when clicked/clicked on.
- Previously this was happening when clicking on the logo:
this is what the logos without transparent background look like:
Added alt text for logo, main link and secondary link. Made it so if links or a logo are being used without an alt text, then an error will occur. Can change this if we want to be more flexible but thought it would be good for encouraging people to take accessibility into account.
Changed the following to line up with the change of requiring alt text for logos: