Move run_example to own directory #120
Conversation
There was a problem hiding this comment.
Thanks Cam! App runs fine with run_example() and devtools::check() passes all tests for me.
devtools::test() I get some errors though - cant find the skip_to_main() function, also skips the tests for testing the example app, can see it's meant to skip on CRAN but is this expected behaviour here? I have also just updated R on my mac so may be a me problem! I'll let you know if that turns out to be the case in this thread, but do you get the same errors? 
cjrace
force-pushed
the
move-runexample-to-own-directory
branch
from
2bfc560 to
f125727
Compare
|
Rebased on top of the latest from the master branch and resolved conflicts, force pushing the updates here - will look into your comment now @sarahmwong - I don't think that is expected! |
|
I think I've worked it out @sarahmwong 🤞 to reinstall the package on my laptop generally, after that, the tests passed - I think the changes in the footer function had been made since I'd last installed so that was causing the error. In theory, if you reinstall the package from GitHub and then run again it should work fine with either |
|
Thanks Cam! You're right both now work :D Weirdly says it skips the example_app test but then goes ahead and runs example_app basic_load test so think skip_on_cran is working as expected - happy to approve |
Overview of changes
After #118 failed, I'm now going for the bigger change of creating a separate directory for the
run_example()app, so I have a directory I can point shinyapps.io to for the deployment. Have been following the notes in a shinytest2 vignette. Hoping this approach should work...Relates to #110 but won't necessarily resolve it - I will need to check that after it goes into master.
run_example()still runs the example app.PR Checklist
devtools::check()Reviewer instructions
I copied the contents of run_example into an app.R file in it's own directory so nothing material should have change in the example app (aside from the note around where to find the code).
Main thing is to check that run_example() still opens an app for you, and that the package checks pass