Skip to content

docs: ICP features: caller ID #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

docs: ICP features: caller ID #5170

merged 2 commits into from
Jun 2, 2025

Conversation

jessiemongeon1
Copy link
Contributor

No description provided.

@jessiemongeon1 jessiemongeon1 requested a review from a team as a code owner May 22, 2025 22:04
jessiemongeon1
jessiemongeon1 commented May 22, 2025
View reviewed changes
doc/md/icp-features/3-caller-identification.md Outdated

In this example, the canister assigns roles dynamically, allowing its controller to manage administrators and members, each with different permissions.

```motoko no-repl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example does not compile, returns several errors

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any instances of actor classes will not work on icp ninja because it ignores all cycle calls. i also think shared functions without the public keyword might work in the repl but not on the playground

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stand corrected. It seems you can deploy actor class on the playground now.

jessiemongeon1
jessiemongeon1 commented May 22, 2025
View reviewed changes
doc/md/icp-features/3-caller-identification.md
sidebar_position: 3
---

# Caller identification
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the examples on this page should be wrapped in actors since they're rather long and showcase entire access control examples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Will do

@jessiemongeon1 jessiemongeon1 merged commit d5ecb49 into dfinity:docs-restructure Jun 2, 2025
4 of 16 checks passed
jessiemongeon1 added a commit that referenced this pull request Jun 2, 2025
@jessiemongeon1 @Demali-876
@crusso @Copilot @raymondk @rvanasa
docs: restructure working PR (#4866)
803fdef 
* Remove overview

* fix

* add skeleton for docs

* docs structure

* misc fixes

* Update count-v1stable.mo

* Update count-v0transient.mo

* docs: rewrite and restructure meet-motoko.md [DRAFT] (#4885)

* docs: rewrite and restructure meet-motoko.md

* fix: address feedback

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

---------

Co-authored-by: Jessie Mongeon <[email protected]>

* Fundamentals to Declarations [Draft] (#4894)

* docs: rewrite and restructure meet-motoko.md

* fix: address feedback

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* fundamental to pipes draft.

* updated fundamentals draft.

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/getting-started.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/integers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/integers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/integers-numbers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/assertion.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* updates to draft

* updates to imports.md

* updates to printing values

* updates integer

* update to Float

* update to Characters

* update to Text

* update to literals

* update to whitespace

* updates

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/basic-syntax/defining_an_actor.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/floats.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/text.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/floats.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/integers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/defining_an_actor.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/integers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/literals.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/whitespace.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/printing_values.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/printing_values.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/whitespace.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/integers-numbers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/text.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/traps.md

Co-authored-by: Jessie Mongeon <[email protected]>

* nix fix + loops intro

* updates

* updates to expression declarations

* Update doc/md/fundamentals/expressions/control-flow/block.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/contol_flow_structs.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/contol_flow_structs.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/contol_flow_structs.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/for_loop.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/for_loop.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/if-else.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/for_loop.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/if-else.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/option.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/record.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/loop.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/option.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/record.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/record.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/record.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/switch.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/tuple.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/tuple.md

Co-authored-by: Jessie Mongeon <[email protected]>

* code comments and commit suggestions

* Delete doc/md/fundamentals/expressions/control-flow/control_flow.md

Remove control flow

* Rename contol_flow_structs.md to basic_control_flow.md

* Apply suggestions from code review

Suggestion batch commit

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/keywords.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* sidebar duplication removals

---------

Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* Docs Restructure: Covering primitives to shared types + Actor->Control-flow + Conversions (#4923)

* docs: rewrite and restructure meet-motoko.md

* fix: address feedback

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* fundamental to pipes draft.

* updated fundamentals draft.

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/getting-started.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/integers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/integers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/integers-numbers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/assertion.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* updates to draft

* updates to imports.md

* updates to printing values

* updates integer

* update to Float

* update to Characters

* update to Text

* update to literals

* update to whitespace

* updates

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/basic-syntax/defining_an_actor.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/operators.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/floats.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/text.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/floats.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/integers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/defining_an_actor.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/meet-motoko.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/integers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/imports.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/literals.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/whitespace.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/printing_values.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/printing_values.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/whitespace.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/integers-numbers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/text.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/traps.md

Co-authored-by: Jessie Mongeon <[email protected]>

* nix fix + loops intro

* updates

* updates to expression declarations

* Update doc/md/fundamentals/expressions/control-flow/block.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/contol_flow_structs.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/contol_flow_structs.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/contol_flow_structs.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/for_loop.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/variant.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/for_loop.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/if-else.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/for_loop.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/if-else.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/option.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/record.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/loop.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/option.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/record.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/record.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/record.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/switch.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/tuple.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/expressions/control-flow/tuple.md

Co-authored-by: Jessie Mongeon <[email protected]>

* code comments and commit suggestions

* Delete doc/md/fundamentals/expressions/control-flow/control_flow.md

Remove control flow

* Rename contol_flow_structs.md to basic_control_flow.md

* Apply suggestions from code review

Suggestion batch commit

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/basic-syntax/keywords.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* sidebar duplication removals

* Types Draft: Covering primitives to stable types

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Move tables and complete Bank.getBalance()

* actors-> control flow + conversions

* Update doc/md/fundamentals/types/mutable-arrays.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* add missing context

* Update async_actors.md

* remaining fundamentals

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* final clean up

---------

Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/async_actors.md

Co-authored-by: Copilot <[email protected]>

* chore: rename and add category files (#4950)

* rename and add category files

* Update doc/md/fundamentals/expressions/control-flow/_category_.yml

Co-authored-by: Jessie Mongeon <[email protected]>

---------

Co-authored-by: Jessie Mongeon <[email protected]>

* revisions to the structure, page organization, condensing fragmented content, testing examples

* link updates, no-repl fixes, misc revisions

* link updates, no-repl fixes, misc revisions

* docs: update icp features section (#5031)

* revise ICP features pages

* revise ICP features pages

* remove old docs pages

* remove old docs pages

* merge master

* remove unused files

* misc fixes

* misc fixes

* Update 0.11.0-migration-guide.md

* merge conflict

* Apply suggestions from code review

Co-authored-by: Ryan Vandersmith <[email protected]>

* Update doc/md/icp-features/1-randomness.md

Co-authored-by: Ryan Vandersmith <[email protected]>

* Update doc/md/icp-features/1-randomness.md

Co-authored-by: Ryan Vandersmith <[email protected]>

* Update doc/md/icp-features/1-randomness.md

Co-authored-by: Ryan Vandersmith <[email protected]>

* Update doc/md/icp-features/4-candid-serialization.md

Co-authored-by: Ryan Vandersmith <[email protected]>

* apply suggestions

* apply suggestion

* Remove changes outside of docs/md (#5059)

* Motoko team suggestions (#5062)

* motoko team suggestions

* Apply suggestions from code review

---------

Co-authored-by: Jessie Mongeon <[email protected]>

* Use 'docs-restructure' as base branch (#5070)

* Update doc/md/fundamentals/1-basic-syntax/4-numbers.md

* docs suggestions

* Update doc/md/fundamentals/2-types/8-immutable-arrays.md

Co-authored-by: Claudio Russo <[email protected]>

* restore old files; only keep chapters 1/2

* Update doc/md/fundamentals/2-types/8-immutable-arrays.md

Co-authored-by: Claudio Russo <[email protected]>

* apply suggestions

* code suggestions

* apply suggestions

* fix

* apply suggestions

* home and nav updates

* home and nav updates

* home and nav updates

* home and nav updates

* Chapters 1 & 2 Revisions 05-02-2025 (#5113)

* Chapter's 1 & 2 Initial commit

* misc updates

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Manual revisions for defining an actor.

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* manual changes characters and strings

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Split result and options

* Char and text

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* Char Text

* remove private public

* Suggestion

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* shared

* Formatting

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* updates

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>

* line example

* Inferred types + update whitespace example

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>

* fixes immutable and mutable arrays

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>

* rephrase when to use immutable arrays

* updates

* modified table

* suggestion

* object class suggestion

* swap suggestion

* 2nd pass + updates to Result

* update icp ninja link

* actor suggestion

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* remove actor class reference

* Update doc/md/fundamentals/1-basic-syntax/4-numbers.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* revised function

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* aritmetic suggestion

* Update doc/md/fundamentals/2-types/1-primitive-types.md

Co-authored-by: Jessie Mongeon <[email protected]>

* suggestion

* update urls

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* wrap tic tac toe

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* wrap actor

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/4-tuples.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/4-tuples.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/2-types/4-tuples.md

Co-authored-by: Jessie Mongeon <[email protected]>

* suggestion

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* wrap actors

* Update doc/md/fundamentals/2-types/15-type-conversions.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* updates

* update returns

* Update doc/md/fundamentals/2-types/3-functions.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* wraps

* Update doc/md/fundamentals/1-basic-syntax/1-defining-an-actor.md

Co-authored-by: Claudio Russo <[email protected]>

* updates

* updates

* Update doc/md/fundamentals/1-basic-syntax/2-imports.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/1-basic-syntax/2-imports.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/2-types/10-options.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/10-options.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/11-results.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/10-options.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/10-options.md

Co-authored-by: Jessie Mongeon <[email protected]>

* indent

* Update doc/md/fundamentals/2-types/10-options.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/11-results.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/1-basic-syntax/1-defining-an-actor.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/2-types/3-functions.md

Co-authored-by: Claudio Russo <[email protected]>

* updates

* Update doc/md/fundamentals/1-basic-syntax/1-defining-an-actor.md

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* match counters in whitespace

* fix | rendering

* Update doc/md/fundamentals/2-types/1-primitive-types.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* updates

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* Update

* fix brokem in-line code

* updates

* 3rd review and final pass

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>

* fix

* fix indentation of actor bodies and misc leftover edits

* docs: 1-variable-declarations.md (#5154)

* 1-variable-declarations.md

* Demali's Changes

* reapply edits

* Update doc/md/fundamentals/3-declarations/1-variable-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update 1-variable-declarations.md

* Update doc/md/fundamentals/3-declarations/1-variable-declarations.md

* Update doc/md/fundamentals/3-declarations/1-variable-declarations.md

* Update doc/md/fundamentals/3-declarations/1-variable-declarations.md

---------

Co-authored-by: Demali-876 <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* docs: 2-function-declarations (#5155)

* 2-funcdelcarations

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update 2-function-declarations.md

* Update doc/md/fundamentals/3-declarations/2-function-declarations.md

---------

Co-authored-by: Claudio Russo <[email protected]>

* docs: 3-object-declaration (#5156)

* 3 object decl

* 3 object decl

* Update 3-object-declaration.md

* Update doc/md/fundamentals/3-declarations/3-object-declaration.md

Co-authored-by: Claudio Russo <[email protected]>

* Update 3-object-declaration.md

* Update 3-object-declaration.md

---------

Co-authored-by: Claudio Russo <[email protected]>

* docs: 7-module-declarations (#5162)

* Module declarations

* Update doc/md/fundamentals/3-declarations/7-module-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/7-module-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/7-module-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/7-module-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/7-module-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/7-module-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/7-module-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/7-module-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

---------

Co-authored-by: Claudio Russo <[email protected]>

* docs: 6-expression-declaration (#5160)

* expression decl

* Update doc/md/fundamentals/3-declarations/6-expression-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/6-expression-declarations.md

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

---------

Co-authored-by: Claudio Russo <[email protected]>

* docs: 5 type declarations (#5159)

* type declarations

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

---------

Co-authored-by: Claudio Russo <[email protected]>

* draft: left-over suggestions (#5173)

* fix bounds section, leaving future todos

* doc: rework section on subtyping (#5185)

* more rephrasing

* reworking subtyping

* minor tweaks

* reword variant and record subtyping

* T1/T2 -> T/U

* mention mutable fields

* make all no-repl, _inlude

* Update doc/md/fundamentals/2-types/14-subtyping.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/14-subtyping.md

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/14-subtyping.md

* Update doc/md/fundamentals/2-types/14-subtyping.md

* Update doc/md/fundamentals/2-types/14-subtyping.md

* Apply suggestions from code review

---------

Co-authored-by: Jessie Mongeon <[email protected]>

* Update doc/md/fundamentals/2-types/12-advanced-types.md

* Update doc/md/fundamentals/2-types/12-advanced-types.md

---------

Co-authored-by: Jessie Mongeon <[email protected]>

* docs: 4 class declarations  (#5158)

* 4 class declarations

* Update 4-class-declarations.md

* add actor classes

* Update 4-class-declarations.md

* Update 4-class-declarations.md

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/3-declarations/4-class-declarations.md

---------

Co-authored-by: Claudio Russo <[email protected]>

* misc leftover changes

* Canpack (#5192)

* mo-doc (#5194)

* docs: Motoko tooling: VS Code extension (#5195)

* VS Code

* Update doc/md/motoko-tooling/4-motoko-vs-code.md

Apply Ryan Suggestion

Co-authored-by: Ryan Vandersmith <[email protected]>

---------

Co-authored-by: Demali.icp <[email protected]>
Co-authored-by: Ryan Vandersmith <[email protected]>

* re-open dev container PR (#5201)

* docs: block expressions (#5166)

* Block espressions

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Add remaining suggestion

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/4-control-flow/4-blocks.md

---------

Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Demali.icp <[email protected]>

* docs: control flow loops (#5164)

* control flow 2

* control flow 2

* formatting

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* fix spacing

* Add loop while

* Update doc/md/fundamentals/4-control-flow/2-loops.md

---------

Co-authored-by: Demali-876 <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* docs: control flow - conditionals (#5165)

* Conditionals

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/4-control-flow/3-conditionals.md

---------

Co-authored-by: Claudio Russo <[email protected]>

* docs: basic control flow (#5163)

* Control flow 1

* formatting

* updates

* revert unnecessary changes

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/4-control-flow/1-basic-control-flow.md

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* update option block example

* fix spacing

* Update doc/md/fundamentals/4-control-flow/1-basic-control-flow.md

* Update doc/md/fundamentals/4-control-flow/1-basic-control-flow.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/4-control-flow/1-basic-control-flow.md

* Update doc/md/fundamentals/4-control-flow/1-basic-control-flow.md

---------

Co-authored-by: Demali-876 <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>

* docs: control flow switch (#5167)

* switch

* Update doc/md/fundamentals/4-control-flow/5-switch.md

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/4-control-flow/5-switch.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/4-control-flow/5-switch.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/4-control-flow/5-switch.md

Co-authored-by: Claudio Russo <[email protected]>

* Update doc/md/fundamentals/4-control-flow/5-switch.md

Co-authored-by: Claudio Russo <[email protected]>

---------

Co-authored-by: Claudio Russo <[email protected]>

* docs: icp features randomness (#5168)

* Randomness

* updates

---------

Co-authored-by: Demali-876 <[email protected]>

* docs: ICP features: caller ID (#5170)

* callerid

* Update 3-caller-identification.md

* docs: ICP Features - Stable memory (#5190)

* stable mem

* Update 5-stable-memory.md

* docs: ICP Features: System functions (#5191)

* System functions

* Update 6-system-functions.md

* docs: Async data (#5196)

* async data

* Apply suggestions from code review

Co-authored-by: Claudio Russo <[email protected]>

* Update 5-actors-async.md

---------

Co-authored-by: Claudio Russo <[email protected]>

* docs: Mutable state (#5197)

* state

* Update 6-state.md

* docs: Modules and imports (#5199)

* Modules

* Modules

* Modules

* Update 8-modules-imports.md

* docs: Messaging (#5198)

* messaging

* Update 7-messaging.md

* docs: Data persistence (#5200)

* data persistence

* Update 9-data-persistence.md

* error handling (#5203)

* docs: Garbage collection (#5204)

* Garbage collection

* Update 12-garbage-collection.md

* Pattern matching (#5202)

* docs: ICP features timers (#5169)

* Timers

* Update 2-timers.md

* Update 2-timers.md

* docs: ICP features: Candid (#5171)

* Candid

* Update 4-candid-serialization.md

* add EOP docs

* fix links

* fix links

* fix links

* fix links

* fix links

* fix links

* fix links

* fix links

* fix links

---------

Co-authored-by: Demali.icp <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: raymondk <[email protected]>
Co-authored-by: raymondk <[email protected]>
Co-authored-by: Ryan Vandersmith <[email protected]>
Co-authored-by: Ryan Vandersmith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demali-876 Demali-876 Demali-876 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessiemongeon1 @Demali-876