Fixed the menu location in order to fit on the display it is activated #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6a46b7f.
This issue was added when I remove a old workaround for multiple display setup and didn't pay attention that it was also making the menu window to fit on a display. I revert the commit and rewrote it. It's not perfect for setups where the displays have different resolution. In that situation if a window is shared by multiple displays in a location where a window is scaled the correct dimensions can not be safely evaluated and then we can still get the popup menu cropped. NOTE: Fixed the popup menu location that can be shown out of screen. Thanks to Xavier
This issue was introduced by the fix for another menu issue that was crashing Wings3D when closing a window with the context menu active (commit: #be68730) The fix redraw the entire menu unselected before it be displayed. It was also needed to find for the window of the submenu item because it's not stored in the object property of menudata. NOTE: Fixed the menu selection that was letting garbage. Thanks to sciroccorics
dgud
reviewed
Sep 24, 2024
Comment on lines
-394
to
+401
| {move, Pos} -> | ||
| {move, {X,Y}} -> | ||
| Frame = maps:get(frame, MenuData), | ||
| Pos = fit_menu_on_display(Frame, {X,Y}), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OBS: There are two fix on this PR because the second one was causing conflict if it was separated.
1) This issue was added when I remove a old workaround for multiple display
setup and didn't pay attention that it was also making the menu window
to fit on a display. I revert the commit and rewrote it.
It's not perfect for setups where the displays have different resolution.
When the window is placed entirely on a display everything works fine, but
if a window is shared by multiple displays, in a location where
a window is scaled, the correct dimensions can not be safely evaluated
and then we can still get the popup menu cropped. (see images bellow)
2) This issue was introduced by the fix for another menu issue that was crashing
Wings3D when closing a window with the context menu active (commit: #be68730).
* It can be seen in the previous image in which we see two items selected when the menu was shown.
The fix redraw the entire menu unselected before it be displayed. It was also
needed to find for the window of the submenu item because it's not stored in
the object property of menudata.
NOTE:
Thanks to Xavier
Thanks to sciroccorics