remove unused constructors for error messages #2657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2651 I noticed that several error message constructors were not used to create any error messages in the type-checker. Those constructors are:
InvalidHandlerOutputTypeInvalidListElementMustUpdateARecordRecordTypeMismatchIn all those cases, the error description shows some example errors but those errors are reported via different error messages. There is no code anywhere in this repository that creates error values or raises exceptions using these constructors.
For example, it looks like
InvalidListElementwas intended to describe the type error in[1, True] : List Natural. However, Dhall reports the error "List elements should all have the same type" created viaMismatchedListElements. The type error in[1, 2] : List Textis "Expression does not match type annotation".I would like to remove all code around those unused error message constructors.