Some typos and let-syntax? #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the files I stumbled over some typos, figured I'd PR instead of creating an issue for such minor things.
One thing that touches a significant number of files is a lack of
inkeywords corresponding to consecutiveletkeywords.According to the tutorial and my dhall version they're required.
Maybe this changed in a more recent release though?
My
dhall formatalso makes quite a few whitespace changes.Maybe you want to setup a CI job that automatically typechecks and formats all dhall files? I imagine that'd be pretty useful to other people using dhall.