forked from vlsunil/edk2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rv64 universal payload review #5
Open
dhaval-rivos
wants to merge
14
commits into
RiscV64QemuVirt
Choose a base branch
from
RV64UniversalPayload_review
base: RiscV64QemuVirt
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until more optimized extensions are available Use generic library functions Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Create separate build files for RV64 as current implemenation is specific to X86 to make it more readable and manageable. Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Removed all IA related code and hooks from the build files Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Implemented necessary hooks in UniversalPayload to ensure it can support RV64 DxeCore entry. Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
These patches are WIP patches to statically add required HOBs and change some boot flow logic to be able to boot payload till UEFI shell Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Remove unnecessary bootloader related modules which are not required in the current flow Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Align with ABI implementation to ensure Payload receives FDT data and hart id correctly Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Create FDT HOB as per Uni Payload Requirement Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
1. Move BL specific HOB creation outsider Universal Payload UefiPayload 2. Add FDT based HOB creation as a POC Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Since we are on simulation model right now we do not need to have this functionality Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Some early debug prints (Apriori) are enabled with this functionality Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Add required modules to enumerate virt qemu devices listed in fdt Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Adding supoprt for device tree enumeration. This protocol is required to trigger enumeration of devices. Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
There was some runtime support missing which was causing exception when OS was calling EFI. Added required modules. Cc: Sunil V L <[email protected]> Signed-off-by: Dhaval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC patchset to enable RV64 support in UniversalPayload. P.S. some patches are WIP and require more discussions but kept here for sake of flow completeness.