[15.0][ADD] Product Valuation #1141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 15.0 #1141 +/- ##
==========================================
+ Coverage 67.73% 67.84% +0.11%
==========================================
Files 898 910 +12
Lines 14672 14905 +233
Branches 2348 2371 +23
==========================================
+ Hits 9938 10113 +175
- Misses 4029 4079 +50
- Partials 705 713 +8 ☔ View full report in Codecov by Sentry. |
This update introduces a product valuation history feature, providing a record of past product valuations. This enhancement allows users to review historical valuation data. In addition, corrections were made to several typos, enhancing overall code clarity and maintainability. Notably, the word 'Ammount' was amended to the correct spelling, 'Amount'. Additionally, the 'Year' and 'Month' fields were updated from integer to character type, increasing flexibility for data input.
The code has been updated to include debit and credit fields in both Product Valuation and Product Valuation History. These new fields have been added to the existing views and used to calculate the total amount. Furthermore, a pivot view for the product valuation history has also been established to provide clearer and more robust data analysis.
Added "quantity_in" and "quantity_out" fields to product valuation to distinguish incoming and outgoing stock. They have been integrated into the product valuation view and model for transparency and better tracking of stock changes. The database query in "product_valuation.py" was updated to handle these new fields.
An entry for the 'deltatech_valuation' module has been added to the README.md file in the Odoo addons repository. This module, tagged as 'Product Valuation', is now visible with its version and other details.
The product valuation view and model were updated to include more fields such as "quantity_in", "quantity_out", "debit" and "credit". In addition, several fields in the model's SQL queries and calculation script were revised to better handle the calculations for each valuation. Now, the model can separately track each products' incoming and outgoing quantities and their corresponding debit and credit values.
…uct valuation The product valuation model has been updated to include initial and final quantity/amount fields. These new fields are considered in all the historical calculations and are also included in the product valuation view. Additionally, a valuation area menu item has been introduced and some instructions have been added to the README file for initial server setup.
Added unique SQL constraints to product valuation and product valuation history to ensure data integrity. Also streamlined SQL queries for generating series and updated quantity and amount initial calculations.
The 'date' field in the product_valuation model was previously optional. This commit changes the 'date' field to be required and indexed, which ensures that every record will have a date, and improves performance when making date-based queries.
The change in the product_valuation.py code imports the relativedelta method from dateutil. This enables the calculation of the last day of the month for a specified date, enhancing the effectiveness of managing product valuation by date.
The refactoring aims to simplify and optimize the product valuation calculations by restructuring the SQL queries. The calculation has been split into smaller, more manageable sub-queries resulting in increased readability and performance. The changes also include better control over data selection and updates for product valuation.
Implemented improvements to SQL code in the product valuation module to enhance its readability and maintainability. The commit simplifies the implementation of an "INSERT INTO" statement and consolidates multiple instances of repetitive code, thereby optimizing the overall codebase without compromising on functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.