-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config.ts): add skipCommitMessageCheck config key #19
base: dev
Are you sure you want to change the base?
Conversation
Lars-
commented
Mar 15, 2023
- add skipCommitMessageCheck config key
- add support for skipCommitMessageCheck config key to skip commit message check if set to true
feat(prepare-commit-msg-hook.ts): add support for skipCommitMessageCheck config key to skip commit message check if set to true
src/commands/config.ts
Outdated
@@ -10,7 +10,8 @@ import { COMMANDS } from '../CommandsEnum'; | |||
export enum CONFIG_KEYS { | |||
OPENAI_API_KEY = 'OPENAI_API_KEY', | |||
description = 'description', | |||
emoji = 'emoji' | |||
emoji = 'emoji', | |||
skipCommitMessageCheck = 'skipCommitMessageCheck' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets rename it to skipCommitMsgHookSourceCheck
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome @Lars- thanks! could you change base branch to dev
instead of master
pls <3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lars- there is a conflict, could you solve pls and let's merge it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue wasn't there when I sent the PR, so you may change it
…okSourceCheck refactor(prepare-commit-msg-hook.ts): update reference to skipCommitMessageCheck to skipCommitMsgHookSourceCheck update variable name
…n hook Added explanation to readme
Also added a part to readme.md |
Stale pull request message |
please pull latest |
I don’t have the time for that, but you should be able to change the code in the PR yourself. |
Am I missing this functionality in the current release or do I need to fork this repo? @di-sukharev |