Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config.ts): add skipCommitMessageCheck config key #19

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Lars-
Copy link

@Lars- Lars- commented Mar 15, 2023

  • add skipCommitMessageCheck config key
  • add support for skipCommitMessageCheck config key to skip commit message check if set to true

feat(prepare-commit-msg-hook.ts): add support for skipCommitMessageCheck config key to skip commit message check if set to true
@Lars- Lars- mentioned this pull request Mar 15, 2023
@@ -10,7 +10,8 @@ import { COMMANDS } from '../CommandsEnum';
export enum CONFIG_KEYS {
OPENAI_API_KEY = 'OPENAI_API_KEY',
description = 'description',
emoji = 'emoji'
emoji = 'emoji',
skipCommitMessageCheck = 'skipCommitMessageCheck'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets rename it to skipCommitMsgHookSourceCheck?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome @Lars- thanks! could you change base branch to dev instead of master pls <3

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also done!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lars- there is a conflict, could you solve pls and let's merge it!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue wasn't there when I sent the PR, so you may change it

…okSourceCheck

refactor(prepare-commit-msg-hook.ts): update reference to skipCommitMessageCheck to skipCommitMsgHookSourceCheck
update variable name
@Lars-
Copy link
Author

Lars- commented Mar 15, 2023

Also added a part to readme.md

@Lars- Lars- changed the base branch from master to dev March 16, 2023 14:53
@github-actions
Copy link

Stale pull request message

@di-sukharev
Copy link
Owner

please pull latest dev and run npm run build to solve conflicts @Lars-

@Lars-
Copy link
Author

Lars- commented Mar 3, 2024

I don’t have the time for that, but you should be able to change the code in the PR yourself.

@JUSTINMKAUFMAN
Copy link

Am I missing this functionality in the current release or do I need to fork this repo? @di-sukharev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants