Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): 网格对齐改为开关控制 & 修复初始化时流程图偏移问题 #2006

Merged
merged 5 commits into from
Dec 12, 2024
Merged

fix(core): 网格对齐改为开关控制 & 修复初始化时流程图偏移问题 #2006

merged 5 commits into from
Dec 12, 2024

Conversation

DymoneLewis
Copy link
Collaborator

fix #2001

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8ec01ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DymoneLewis DymoneLewis mentioned this pull request Dec 12, 2024
Closed
boyongjiong
boyongjiong reviewed Dec 12, 2024
View reviewed changes
packages/core/src/LogicFlow.tsx Outdated
gridSize,
} = this.graphModel
// 开启网格对齐且当前画布网格尺寸与网格对齐尺寸不一致时，或者关闭网格对齐且当前画布网格尺寸不为1时，更新画布网格尺寸
if ((snapGrid && gridSize !== size) || (!snapGrid && gridSize !== 1)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块儿的判断有点绕，梳理了一下感觉是不是可以不用

删除之后确认一下

packages/core/src/model/GraphModel.ts Show resolved Hide resolved
@boyongjiong boyongjiong merged commit f6222fb into master Dec 12, 2024
1 check passed
@boyongjiong boyongjiong deleted the bugfix/rendered-edge-move branch December 12, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyongjiong boyongjiong boyongjiong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report]: 折线调整过边的位置后，重新渲染时，边的位置被重置成默认状态
2 participants
@DymoneLewis @boyongjiong