-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new compressor API to reserve CID for network flow #7
Draft
didier-barvaux
wants to merge
7
commits into
master
Choose a base branch
from
dev_reserve_context
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MartinFretigne please review this MR, tell me if it matches your expectations |
MartinFretigne
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect, thank you ! Note : I'm no longer contracting for the company that needed this, I hope it will help others.
* add compressor API rohc_comp_reserve_ctxt() to reserve a given Context ID (CID) for a network flow (identified by one of its packet). * add rohc_comp_unreserve_ctxt() to unreserve a given Context ID (CID). * update the unit test for compressor API to test the two new functions. * add option --reserve-max-cid to the non-regression test to make it reserve the context with CID = MAX_CID for the first network flow. The new compressor API is an idea suggested by Martin Fretigne on #6
didier-barvaux
force-pushed
the
dev_reserve_context
branch
from
December 26, 2019 14:12
5497102
to
dafd0ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new compressor API to reserve CID for network flow
ID (CID) for a network flow (identified by one of its packet).
reserve the context with CID = MAX_CID for the first network flow.
The new compressor API is an idea suggested by Martin Fretigne on
#6