Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new compressor API to reserve CID for network flow #7

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

didier-barvaux
Copy link
Owner

add new compressor API to reserve CID for network flow

  • add compressor API rohc_comp_reserve_ctxt() to reserve a given Context
    ID (CID) for a network flow (identified by one of its packet).
  • add rohc_comp_unreserve_ctxt() to unreserve a given Context ID (CID).
  • update the unit test for compressor API to test the two new functions.
  • add option --reserve-max-cid to the non-regression test to make it
    reserve the context with CID = MAX_CID for the first network flow.

The new compressor API is an idea suggested by Martin Fretigne on
#6

@didier-barvaux didier-barvaux self-assigned this Sep 26, 2019
@didier-barvaux
Copy link
Owner Author

@MartinFretigne please review this MR, tell me if it matches your expectations

Copy link

@MartinFretigne MartinFretigne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, thank you ! Note : I'm no longer contracting for the company that needed this, I hope it will help others.

* add compressor API rohc_comp_reserve_ctxt() to reserve a given Context
  ID (CID) for a network flow (identified by one of its packet).
* add rohc_comp_unreserve_ctxt() to unreserve a given Context ID (CID).
* update the unit test for compressor API to test the two new functions.
* add option --reserve-max-cid to the non-regression test to make it
  reserve the context with CID = MAX_CID for the first network flow.

The new compressor API is an idea suggested by Martin Fretigne on
#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants