-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 Configure xdist group for session fixtures #1312
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f865a1
to
1b67a3d
Compare
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
cl0ete
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently run with
--dist loadfile
, which groups tests by file / module. This means "session" scoped fixtures become module-scoped, which we don't want. Therefore, switch to--dist loadgroup
(in charts repo) and configure same group for session fixturesSee: https://pytest-xdist.readthedocs.io/en/stable/distribution.html
Edit: damn, marks applied to fixtures have no effect. So each test using faber / other session scoped fixtures needs to be marked individually ...
⚡ Looked at test durations to spread tests out across xdist group in a logical way to shorten test runs with fewer xdist workers
(the grouping might seem a bit random, but it was based somewhat on pytest --durations result)
🎨 Includes some deduplication, which codacy reported after some files were edited
🔊 Include issuer wallet label in log contexts