Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle data after EOI #16

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

Friendseeker
Copy link
Contributor

Issue

Certain image has Data after EOI and currently jay-peg throws Unknown Version Number exception when decoding these images

Fix

Add reserved attribute in EndOfImageMarker so restructure expects potential data after EOI and does not crash.

Validating the fix

https://github.com/exiftool/exiftool/blob/master/t/images/AFCP.jpg contains data after EOI. jay-peg threw Unknown Version Number exception without the fix, and decodes the image successfully after the fix.

Fixes #6

Copy link
Owner

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@diegomura diegomura merged commit dfb0000 into diegomura:main Sep 23, 2024
3 checks passed
@Friendseeker Friendseeker deleted the data-after-eoi branch September 23, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to decode images with extra data after EOI marker fails
2 participants