Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goto-programs: Replace uses of namespacet::follow #8230

Merged

Conversation

tautschnig
Copy link
Collaborator

This is deprecated. Use suitable variants of follow_tag instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 79.64%. Comparing base (d7b229e) to head (60dc466).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/goto-programs/interpreter.cpp 42.85% 12 Missing ⚠️
src/goto-programs/graphml_witness.cpp 0.00% 5 Missing ⚠️
src/goto-programs/destructor.cpp 80.00% 1 Missing ⚠️
src/goto-programs/interpreter_evaluate.cpp 0.00% 1 Missing ⚠️
src/goto-programs/json_expr.cpp 91.66% 1 Missing ⚠️
src/goto-programs/xml_expr.cpp 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8230   +/-   ##
========================================
  Coverage    79.64%   79.64%           
========================================
  Files         1684     1683    -1     
  Lines       195670   195670           
========================================
+ Hits        155841   155843    +2     
+ Misses       39829    39827    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the cleanup/no-follow-goto-programs branch from b1d1ccf to 3d3095a Compare March 22, 2024 15:48
No need for a local helper that unnecessarily used `follow`.
This is deprecated. Use suitable variants of `follow_tag` instead.
@tautschnig tautschnig force-pushed the cleanup/no-follow-goto-programs branch from 3d3095a to 60dc466 Compare March 22, 2024 19:56
@tautschnig tautschnig merged commit 37a2a8e into diffblue:develop Apr 18, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the cleanup/no-follow-goto-programs branch April 18, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants